Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#260] Translate help to english and help section refactor #303

Merged
merged 11 commits into from
Mar 10, 2021

Conversation

diegomanuel
Copy link
Member

@diegomanuel diegomanuel commented Mar 4, 2021

Issue: #260

It's done by generating one HTML per lang at new dist/help/ dedicated folder, so far: es.html and en.html.
Removed the iframes and loading with ajax.

WIP:

  • Change the help contents when changing current lang on app and the user is currently at the help page (works fine on landing).
  • Review deploy process to ensure the new dist/help folder is correctly served.

@diegomanuel diegomanuel added the enhancement New feature or request label Mar 4, 2021
@diegomanuel diegomanuel added this to the 0.1.9 milestone Mar 4, 2021
@diegomanuel diegomanuel self-assigned this Mar 4, 2021
@diegomanuel diegomanuel marked this pull request as ready for review March 5, 2021 21:43
@@ -34,7 +34,7 @@
</div>
</section>
<footer class="horizontal-central-align">
<small>{% trans "Created with ♥ by Fiqus" %} | COOBS 2020</small>
<small>{% trans "Created with ♥ by Fiqus" %} | COOBS 2021</small>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debería tener el año actual o el año en que surgió? pensé que podría decir "since 2020"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sip podría ser también!
qué dicen @nicolasdimarco / @hernanfiqus ?

@diegomanuel
Copy link
Member Author

Ya están todos los cambios listos, revisen el texto de la traducción y lo mergeamos en cuanto aprueben! 💪

@diegomanuel diegomanuel linked an issue Mar 9, 2021 that may be closed by this pull request
@diegomanuel diegomanuel mentioned this pull request Mar 9, 2021
@diegomanuel diegomanuel merged commit 3b04864 into master Mar 10, 2021
@diegomanuel diegomanuel deleted the 260-translate-help branch March 10, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Traducción] Traducir "ayuda"
3 participants