Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#299] Public actions view #311

Merged
merged 9 commits into from
Apr 19, 2021
Merged

[#299] Public actions view #311

merged 9 commits into from
Apr 19, 2021

Conversation

diegomanuel
Copy link
Member

@diegomanuel diegomanuel commented Apr 6, 2021

Issue: #299

It was added to the app's main menu but we should discuss where and how to display it (needs a better UI/layout).
That will be planned and done in another issue/PR: #313

@diegomanuel diegomanuel added the enhancement New feature or request label Apr 6, 2021
@diegomanuel diegomanuel added this to the 0.1.10 milestone Apr 6, 2021
@diegomanuel diegomanuel self-assigned this Apr 6, 2021
@diegomanuel diegomanuel linked an issue Apr 6, 2021 that may be closed by this pull request
@diegomanuel diegomanuel marked this pull request as ready for review April 15, 2021 20:31
Copy link
Contributor

@mjvallone mjvallone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sólo miré el código, no lo probé andando

api/tests/test_views.py Show resolved Hide resolved
api/views/views.py Outdated Show resolved Hide resolved
Copy link
Contributor

@lucasferraro lucasferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hay un ActionsRankingView.list que entiendo era un antigua forma de consultar las acciones publicas, debería volar?

api/views/views.py Show resolved Hide resolved
@diegomanuel
Copy link
Member Author

Hay un ActionsRankingView.list que entiendo era un antigua forma de consultar las acciones publicas, debería volar?

Podría ser, aunque quizá todavía queramos tener/mostrar algún tipo de "ranking" más adelante (y esa view tiene un lindo ejemplito ya armado).
Por ahora la dejé pero le agregué un @TODO para dejarla marcada para una posible volada a futuro!

@mjvallone mjvallone merged commit 376f263 into master Apr 19, 2021
@mjvallone mjvallone deleted the 299-public-actions-view branch April 19, 2021 21:32
nicolasdimarco added a commit that referenced this pull request Aug 30, 2021
* Fix for NODE_ENV value that was failing on production npm build.

* [#299] Public actions view (#311)

* [#299] Updating deps.

* [#299] Making to work API endpoint + tests.

* [#299] Adding a simple vue screen to display public actions (WIP).

* [#299] Creating infinite-scroll VUE component and making it to work with the API endpoint data.

* Using api service to get balance and fixing parse error on failed response.

* [#299] Making the public actions feed to work from within the app. It should be improved visually in another issue/PR!

* Adding model migration.

* Final adjustments.

* [#299] Removing description column.

* [313] Adding public actions feed to landing app (#314)

* [313] Adding public actions feed to landing app.

* [313] Parsing actions data on sroll (WIP).

* [#313] Done parsing actions data on scroll. WIP on modal+styles.

* [#313] Adding API endpoint for public action details.

* [#313] Adding styles and translations for principles and getting public action data from API (WIP details modal).

* [#313] Displaying public action details in a modal (WIP).

* [#313] Completing public action details in a modal.

* [#313] Removing partners involved from public actions (list+details).

* [#319] Fix to partner edit data fetch. (#321)

* [#206] Replacing the download/export balance button by print (#325)

Co-authored-by: Diego Calero <dcalero@fiqus.coop>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Acciones] Crear página pública de la accion
3 participants