Fix #11: Adapt link regex to exclude anchor links #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes the LINK_PATTERN_REGEX to only match links that don't start with a hash by adding '[^#]' in front of the link_url group.
|
Note that this doesn't fix links to anchors on other pages, see #11 (comment). |
|
This currently needs more work, so returning it to draft mode. |
* Add test dependencies and document how to install and run tests * Add regression tests for different types of links * Fix fire1ce#11 properly: Test for `#` prefix in links * Rolls back the broken fix in 8d4b5ee *Fixes fire1ce#11 by checking for a hash prefix in closure code
|
@sdruskat thanks for a PR. l'll try to review it as soon as possible but it may take some time since im busy in the near future. Hope to find some proper time to review the changes. |
@fire1ce Thanks for the quick note! I know what it's like, appreciate your maintenance of this open source project, and don't place any expectations on you w.r.t. a quick review/merge. |
|
Thanks agan. Sorry im very late. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First up, thanks for a very helpful plugin!
I've stumbled over #11 just now and am supplying a fix in this PR.
[^#]in front of thelink_urlgroup.mkdocsv1.5.3 (mkdocs new ., add external page with anchor links, e.g., this README:{{ external_markdown('https://raw.githubusercontent.com/fefong/markdown_readme/master/README.md', '') }}.I hope this is acceptable. Please let me know shold you need anything changed, and feelf free to edit yourself.