Firestore paging adapter #1178

samtstern · 2018-03-01T22:48:21Z

See #17

TODO:

Decide on keeping this in firestore or creating a new firestore-paging
Add a retry() method that the developer can call to make the error state non-terminal
Make paging dependencies 'provided'
Add some tests
Complete documentation
Do we need special end-of-list handling? Should that be its own LoadingState? What about the PageKey?

Change-Id: I9890f5c629ce972624a5cf0fcd5276e83f48d1e5

Change-Id: I4c640d09a0c585f046df32b76b00bd48db94aacb

Change-Id: Id78e7ceee80b670424de4c93a5be2e819aac6fbb

Change-Id: I278fe22606f979011409b37938092763358b4dac

Change-Id: I3b4970fc36dfbbae6045e796577d67e10f015fde

Change-Id: I4102d360594aeb75183f0ac8f1d300826de3b47f

samtstern · 2018-03-01T23:01:07Z

cc @puf

Change-Id: I2264ada2d13cf9c667680f3a278f7b5e2edf0cb0

Change-Id: I75cd769dd3f9cd4c6d6cc1de13d411646827430c

Change-Id: I2be8141c859ba84994b4d9eeb624d2893aa02c3a

Change-Id: Ifc3ab274dcd2df184901452b26e1fe1cbe68f581

samtstern · 2018-03-05T19:18:14Z

@morganchen12 at a high level, how does this compare to what you've tried on iOS?

SUPERCILEX · 2018-03-15T20:34:16Z

@samtstern Without looking at any code, my main concern is that the first issues people are going to submit will be something along the lines of "Paginated data not updating". Also, it'd make me so sad to see a Firebase app with the infamous refresh button. 😢😂 Have you looked at the Paging Library? When I first played with it, I couldn't get things to work out nicely, but that was way back in alpha 1. It should remove a bunch of boilerplate and support changes by passing in new lists and doing diffs on a background thread. The focus is more directed towards supporting Room, but I think we could make it work. Do you want to investigate, or should I?

samtstern · 2018-03-15T20:53:09Z

@SUPERCILEX I can definitely take a look there. I thought it was Room-only so hadn't really looked.

I have a feeling that we're going to have so many issues if we try to maintain listeners on the paginated data ... but we can take another look at that.

samtstern · 2018-03-15T23:49:12Z

@SUPERCILEX ok the Paging library is f***ing awesome! I am at least not embarassed since my design was a lot like theirs, but theirs is way cleaner and best of all I don't have to maintain it.

Before I go that route entirely:

Do you have any idea if the paging library unloads old pages? As far as I can tell the memory usage doesn't grow wildly as I scroll, but it doesn't seem to ever unload anything.
The paging library definitely won't allow us to update individual items as they change. I am fine with that, but you seem concerned. Any ideas?
I don't want to release until it hits at least beta, preferably stable. I dunno if you feel differently.

SUPERCILEX · 2018-03-18T04:04:21Z

@samtstern Haha, I thought you might like it! The Architecture Components team is doing an amazing job of perfecting and investing in all of their APIs so I'd expect nothing less from them. 😆 To answer your questions:

I've spent a bunch of time digging around the SDK and concluded that no, it doesn't drop pages yet. If you poke around the PagedStorage, you'll find that ArrayList<List<T>> mPages is only ever added to, nothing is ever removed. I'd assume that'll get fixed before the beta.
Yeah, I see that they haven't addressed that issue yet either. Maybe they're holding off on #1 and are going to pull off a brilliant move where you can get a callback for when old pages die which would let us keep listeners around and make the list real-time. Or not, but I think the first step is to use something like the Paging library so we can focus on building the Firebase features. Isn't that the whole slogan? "Focus on your users," not the infracture? 😆
Absolutely! This is like the second time they broken everybody, so we should definitely wait until the beta comes around (which should be soon?). Once it hits beta, they stop breaking stuff so we'd be good. Not sure where that leaves this PR though, so it's up to you.

samtstern · 2018-03-19T15:25:25Z

@SUPERCILEX thanks for all the info. Even if they don't get to #1 very soon, I profiled my sample app and the memory usage doesn't get too crazy so I think we'll just say please don't use this with very large documents and wait for the paging library people to do the work for us.

As for #2 and #3 let's just say this whole thing is on hold until the paging library gets to at least beta.

Change-Id: I7b7a7da48530817dfad36afd428af7f553e12cd0

Change-Id: Ia8711bfb5b4f8dde11d4ef4630fabf70b945d45e

Change-Id: I5935b36ea30207d0e4b2a8091a258d108bad9d5a

Change-Id: Ic50dfc07ddd51bf318d655df6fae20ab0af28dcc

Change-Id: I863d67d604b1ef768a591d2456e71a7f94730a53

samtstern · 2018-03-29T17:05:33Z

The -alpha7 release of the paging library just came out, and the release notes say beta is next.

Change-Id: I5da44eeb96a9acf4adf76e0ade70b9ae43a4308e

Change-Id: Idaa7d98c4c4712354ff6a4ed10883f8dc78fa898

Change-Id: Icaa6a6e24a65b87bc6d0e5c49059f72f99522d6c

Change-Id: I0d0d763c7e03c7d37390a2a61bd34195e12f2ca6

samtstern · 2018-04-11T21:36:24Z

@SUPERCILEX what would you rather see as far as code splitting:

Make the paging library a "provided" dependency and treat it how we treat Twitter/Facebook
Make a whole new firebase-ui-firestore-paging target

I lean towards (1) since we've done it before and it has the same size savings for people who don't care about paging.

SUPERCILEX · 2018-04-11T22:10:51Z

Yeah, I think you're right. My only concern is that people are going to be confused as to why we have 2 adapters. If I were just browsing the source code, I'd be like "why wouldn't I want a paging adapter?". At some point if the AC team adds an unload callback we might be able to provide realtime updates and deprecate the old adapter or something, but for now, if we go with #1, we need to have really clear docs. 📜😁 Yay, nay?

Change-Id: I435f0713b3cfa4d1dc9c242defa2a4f0c2d216e1

samtstern · 2018-04-12T00:09:35Z

@SUPERCILEX yep I think careful documentation is going to be the main answer here.

As to "why wouldn't I want a paging adapter", that's a good question! I think most people will want paging unless they need to observe non-added/removed changes to individual items in real time.

SUPERCILEX · 2018-04-12T03:25:10Z

Huh, yeah, I guess it depends on the type of app you're building. I'm biased cuz my thing is cross-device collaboration, but I'd imagine most people are using Firestore for the database part primarily. Anyway, SGTM. 👍

I'll go through another round of review tomorrow or Friday. 👏

Change-Id: I6095b5df433c155c993100031b2633ee1670fb2d

SUPERCILEX

@samtstern This is looking really snazzy!

I'm putting myself into the shoes of future me trying to use this for my app, and here are the issues I've come up with (that I don't think should block the PR, but that we should keep in mind):

Config changes. This is the huge beasty here: FirebaseUI 3: Adapter items reload, although there is no change in the data #947 is going to be made waaaaaay worse, especially since we don't have a way to go back to the page the user was on (AFAIK).
Some sort of parser caching like we already have since—especially with the paging adapter—users will be scrolling through a ton of stuff and wastefully creating a ton of objects.

SUPERCILEX · 2018-04-12T20:00:01Z

app/src/main/java/com/firebase/uidemo/database/firestore/FirestorePagingActivity.java

+        ButterKnife.bind(this);
+
+        mFirestore = FirebaseFirestore.getInstance();
+        mProgressBar.setIndeterminate(true);


Can we move this to the XML?

SUPERCILEX · 2018-04-12T20:02:06Z

app/src/main/java/com/firebase/uidemo/database/firestore/FirestorePagingActivity.java

+        setContentView(R.layout.activity_firestore_paging);
+        ButterKnife.bind(this);
+
+        mFirestore = FirebaseFirestore.getInstance();


I'm wondering what the best practices should be... I think we should store the collection as a field, but use the full FirebaseFirestore.getInstance() for other stuff like the batch. And make it final/inline the assignment? Yay, nay?

Gonna do all of that besides the inline assignment (not a fan of that in classes where you don't have a constructor, like Activity or Fragment)

SUPERCILEX · 2018-04-12T20:10:54Z

app/src/main/java/com/firebase/uidemo/database/firestore/FirestorePagingActivity.java

+    @Override
+    public boolean onCreateOptionsMenu(Menu menu) {
+        getMenuInflater().inflate(R.menu.menu_firestore_paging, menu);
+        return super.onCreateOptionsMenu(menu);


We should return true here to ensure the menu is displayed.

SUPERCILEX · 2018-04-12T20:13:56Z

app/src/main/java/com/firebase/uidemo/database/firestore/FirestorePagingActivity.java

+        WriteBatch writeBatch = mFirestore.batch();
+        CollectionReference collRef = mFirestore.collection("items");
+
+        for (int i = 0; i < 500; i++) {


Isn't 500 a bit excessive for a page size of 20? Maybe like 250 or something?

Also, while I've snagged your attention, the pricing for write batches really isn't clear in the docs (no mention, actually). You're still paying for 500 additions, right?

Re: pricing yeah they are priced per-write.

Re: re: pricing thanks! 😁

SUPERCILEX · 2018-04-12T20:15:52Z

app/src/main/res/values/strings.xml

    <string name="title_realtime_database_activity">Real-time database demo</string>
    <string name="title_storage_activity">Storage Image Demo</string>

    <string name="desc_auth">Demonstrates the Firebase Auth UI flow, with customization options.</string>
    <string name="desc_firestore">Demonstrates using a FirestoreRecyclerAdapter to load data from Cloud Firestore into a RecyclerView for a basic chat app.</string>
+    <string name="desc_firestore_paging">Demonstrates using a FirestorePagingAdapter to load/infinite scroll paging data from Cloud Firestore.</string>


... paging ... -> ... paged ...?

SUPERCILEX · 2018-04-12T20:27:09Z

firestore/src/main/java/com/firebase/ui/firestore/paging/FirestorePagingAdapter.java

+        onBindViewHolder(holder, position, mParser.parseSnapshot(snapshot));
+    }
+
+    protected abstract void onBindViewHolder(@NonNull VH holder, int position, T model);


@NonNull T model

SUPERCILEX · 2018-04-12T20:33:21Z

firestore/src/main/java/com/firebase/ui/firestore/paging/PageKey.java

+
+    @Override
+    public String toString() {
+        String startAfter = mStartAfter == null ? "null" : mStartAfter.getId();


String.valueOf(...)? 😁 Or TBH, I'm pretty sure the compiler does this for you if you just inline everything like so:

return "PageKey{" + "StartAfter=" + mStartAfter.getId() + ", EndBefore=" + mEndBefore.getId() + '}';

It's not the ID I am worried about being null, it's mStartAfter and mEndBefore themselves which can be null.

In Kotlin I could use ?. but in Java I have to do this junk.

Whoops, yeah, I completely glossed over that one. What you're doing SGTM 👍

SUPERCILEX · 2018-04-12T20:35:50Z

firestore/src/main/java/com/firebase/ui/firestore/paging/PagingData.java

+        return mLoadingState;
+    }
+
+    public LiveData<FirestoreDataSource> getDataSource() { return mDataSource; }


Since we're not doing this for the other getters/setters, I think we should use line breaks.

I was fooled by IDE trickery

Aren't we all? 🤣

SUPERCILEX · 2018-04-12T20:40:25Z

firestore/src/main/java/com/firebase/ui/firestore/paging/PagingData.java

+ * All of the data the adapter needs.
+ */
+@RestrictTo(RestrictTo.Scope.LIBRARY_GROUP)
+public class PagingData {


I'm wondering if this class is necessary at all... isn't it just casting stuff and forwarding calls along? I feel like it would be simpler to just give our adapter a PagedList casted to the Firestore one and get the original live datas. Wha'd ya think?

You're absolutely right. It was only necessary pre beta6

Unfortunately we can't get rid of the switchmap thing due to the relationship between LivePagedListBuilder and the Factory. This is also something I stole from their samples.

Ah, thanks for the explanation, I was just about to comment.

SUPERCILEX · 2018-04-12T20:42:13Z

firestore/src/main/java/com/firebase/ui/firestore/paging/SnapshotDiffCallback.java

+ * Default diff callback implementation for Firestore snapshots.
+ */
+@RestrictTo(RestrictTo.Scope.LIBRARY_GROUP)
+public class SnapshotDiffCallback<T> extends DiffUtil.ItemCallback<DocumentSnapshot> {


Maybe DefaultSnapshotDiffCallback?

Change-Id: Ic3964c31bbeb4a12c43960352d1c8b9304a8741b

samtstern · 2018-04-13T01:24:42Z

Build failure:

Execution failed for task ':app:preDebugBuild'.

Android dependency 'android.arch.lifecycle:livedata-core' has different version for the compile (1.1.0) and runtime (1.1.1) classpath. You should manually set the same version via DependencyResolution

SUPERCILEX · 2018-04-13T01:25:53Z

@samtstern You've got to add the paging dependency to our sample 😉

Change-Id: I2bd2fa7812350940aff0ba8bc239c9e5b90df55d

Change-Id: I1d5cf1f6d49d5964b7cd5d702ccd7a24db3f79a8

samtstern · 2018-04-13T18:08:48Z

Ok @SUPERCILEX no more TODOs on my end (besides the red build, which I know how to fix). I added tests and docs today.

Change-Id: Ia4ccf0e08509c9720f7b91fdbcb02b6242252c11

Change-Id: I11a56e9d6ff108c75e088983cb5884ad9aafb018

SUPERCILEX

So close!

SUPERCILEX · 2018-04-16T17:30:22Z

firestore/README.md

+
+FirebaseUI offers two types of RecyclerView adapters for Cloud Firestore:
+
+  * `FirestoreRecyclerAdapter` - bind a `Query` to a `RecyclerView` and respond to all real-time


I fancy using — instead of - 😁. Also, should we change the tense to binds [...] responds ...?

SUPERCILEX · 2018-04-16T17:35:34Z

firestore/src/main/java/com/firebase/ui/firestore/paging/FirestorePagingAdapter.java

+    }
+
+    /**
+     * Unsubscribe from paging / scrolling events, no more data will be populated.


Maybe [...] no more data will be populated, but the existing data will remain. since that's different from the other adapter.

SUPERCILEX · 2018-04-16T17:39:06Z

firestore/README.md

+Before using the adapter in your application, you must add a dependency on the support library:
+
+```groovy
+implementation 'android.arch.paging:runtime:1.0.0-beta1'


Should we use 1.x.x instead of a specific version since we're going to forget to update it?

SUPERCILEX · 2018-04-16T17:41:25Z

firestore/README.md

+});
+```
+
+Next create the `FirestorePagingAdapter` object. You should already have a `ViewHolder` subclass


SUPERCILEX · 2018-04-16T17:45:42Z

firestore/README.md

+            @Override
+            public ItemViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
+                // Create the ItemViewHolder
+                // ,,,


Looks someone was a little too far left 😆, ....

SUPERCILEX · 2018-04-16T17:46:22Z

firestore/README.md

+        };
+```
+
+Finally attach the adapter to your `RecyclerView` with the `RecyclerView#setAdapter()`.


... method.

SUPERCILEX · 2018-04-16T17:49:12Z

firestore/README.md

+}
+```
+
+Similarly, the `stopListening()` call removes the snapshot listener and all data in the adapter.


removes all data in the adapter

Is this true? Pretty sure all the data is just going to stay there. Unless you meant to call submitList(Collections.emptyList()) in stopListening()?

SUPERCILEX · 2018-04-16T17:50:51Z

firestore/README.md

+
+#### Paging events
+
+When using the `FirestorePagingAdapter` you may want to perform some action every time data


... , you may ...

morganchen12 · 2018-04-16T18:09:09Z

Whoops, I'm really late on this PR.

This is fundamentally the same approach that we'll use on iOS, since we can't have both realtime and paging/loading new elements with reasonable scaling performance. We don't have a PagingAdapter thing though, so the way Firestore's data is connected to the UI will be a little bit different.

I'm not worried about that though. This LGTM

Change-Id: Iae9801e965664f987e892968df362186b7c9a8f2

jordond · 2018-04-16T18:45:27Z

firestore/README.md

+
+The `FirestorePagingAdapter` binds a `Query` to a `RecyclerView` by loading documents in pages.
+This results in a time and memory efficient binding, however it gives up the real-time events
+afforted by the `FirestoreRecyclerAdaoter`.


Minor typo in FirestoreRecyclerAdapter

Whoops thanks!

Change-Id: I7e3ca99bc9f682e7989a40155b7bbd3437b98559

Change-Id: I2a2ea182a476283c5a95e66d6d013d160c3c4e89

samtstern · 2018-04-16T18:55:13Z

@SUPERCILEX note that I just added a FINISHED loading state which signals end of data set.

Change-Id: I3f1255426bafd74f3855bd05580b6cd2cecd00a6

Change-Id: I882ce0d573d48f87a85d37b821ea6c60c23e675a

muammil · 2018-07-17T12:41:35Z

Is there any way to delete or update item in FirestorePagingAdapter locally?

I have a story app in which users post stories of different languages and in my apps home screen I list all of them sort by date using FirestorePagingAdapter. Now I have added language filtering option that is for example if user opted to English, Dutch and Arabic stories app should only show that in main screen. Since firestore doesn't support OR queries I am unable to do that with query what I am currently doing is just hiding items by setting View.Gone from OnBindViewHolder of the FirestorePagingAdapter. What I need is an option to remove those from PagingAdapter list itself

samtstern added 6 commits February 20, 2018 17:22

Super basic infinite scroll

5109b4c

Change-Id: I9890f5c629ce972624a5cf0fcd5276e83f48d1e5

Make it kinda actually work

cbaaca7

Change-Id: I4c640d09a0c585f046df32b76b00bd48db94aacb

Actual bidirectional unloading

8e08336

Change-Id: Id78e7ceee80b670424de4c93a5be2e819aac6fbb

Some cleanup

75240b7

Change-Id: I278fe22606f979011409b37938092763358b4dac

Separate demo

4d68a56

Change-Id: I3b4970fc36dfbbae6045e796577d67e10f015fde

Some cleanup

6af779c

Change-Id: I4102d360594aeb75183f0ac8f1d300826de3b47f

samtstern mentioned this pull request Mar 1, 2018

Load More option for recyclerview #17

Closed

samtstern added 4 commits March 2, 2018 14:41

Make lint pass

2a5f554

Change-Id: I2264ada2d13cf9c667680f3a278f7b5e2edf0cb0

Basic JavaDoc

51c0d95

Change-Id: I75cd769dd3f9cd4c6d6cc1de13d411646827430c

Break out Page

09f6a6d

Change-Id: I2be8141c859ba84994b4d9eeb624d2893aa02c3a

Space before a semicolon? That's a paddlin

a7153be

Change-Id: Ifc3ab274dcd2df184901452b26e1fe1cbe68f581

Experimenting with the support Paging Library, comitting just for safety

11668e2

Change-Id: I7b7a7da48530817dfad36afd428af7f553e12cd0

samtstern changed the title ~~Firestore paging adapter~~ [ON HOLD] Firestore paging adapter Mar 19, 2018

samtstern added 3 commits March 19, 2018 12:56

Move to alpha6, remove home-grown bits

db39ddf

Change-Id: Ia8711bfb5b4f8dde11d4ef4630fabf70b945d45e

Real adapter and options classes

efc0095

Change-Id: I5935b36ea30207d0e4b2a8091a258d108bad9d5a

Delete Page

45901b7

Change-Id: Ic50dfc07ddd51bf318d655df6fae20ab0af28dcc

samtstern changed the base branch from version-3.3.0-dev to version-3.3.1-dev March 29, 2018 15:29

Merge branch 'version-3.3.1-dev' into firestore-infinite-scroll

4a684f3

Change-Id: I863d67d604b1ef768a591d2456e71a7f94730a53

samtstern added this to the 3.4.0 milestone Mar 29, 2018

samtstern changed the title ~~[ON HOLD] Firestore paging adapter~~ Firestore paging adapter Mar 29, 2018

samtstern added 2 commits March 29, 2018 11:35

alpha7 update

754f945

Change-Id: I5da44eeb96a9acf4adf76e0ade70b9ae43a4308e

Expose Loading State

1ea8834

Change-Id: Idaa7d98c4c4712354ff6a4ed10883f8dc78fa898

samtstern added 2 commits April 11, 2018 11:21

More feedback

cef8528

Change-Id: Icaa6a6e24a65b87bc6d0e5c49059f72f99522d6c

Move diff callback to options

154ecde

Change-Id: I0d0d763c7e03c7d37390a2a61bd34195e12f2ca6

Add retry() in the data source

5391e97

Change-Id: I435f0713b3cfa4d1dc9c242defa2a4f0c2d216e1

Finish retry piping

c749cf4

Change-Id: I6095b5df433c155c993100031b2633ee1670fb2d

SUPERCILEX reviewed Apr 12, 2018

View reviewed changes

Address review feedback

877fb21

Change-Id: Ic3964c31bbeb4a12c43960352d1c8b9304a8741b

samtstern added 2 commits April 13, 2018 09:58

Add some tests

202857d

Change-Id: I2bd2fa7812350940aff0ba8bc239c9e5b90df55d

Add documentation

85967cb

Change-Id: I1d5cf1f6d49d5964b7cd5d702ccd7a24db3f79a8

samtstern added 2 commits April 13, 2018 11:09

Merge branch 'version-3.3.1-dev' into firestore-infinite-scroll

e199385

Change-Id: Ia4ccf0e08509c9720f7b91fdbcb02b6242252c11

Build fix

bf0ac33

Change-Id: I11a56e9d6ff108c75e088983cb5884ad9aafb018

samtstern changed the base branch from version-3.3.1-dev to version-3.4.0-dev April 13, 2018 19:48

SUPERCILEX reviewed Apr 16, 2018

View reviewed changes

Doc updates (review feedback)

8bede03

Change-Id: Iae9801e965664f987e892968df362186b7c9a8f2

jordond reviewed Apr 16, 2018

View reviewed changes

samtstern added 2 commits April 16, 2018 11:53

Handle final page

a081a7f

Change-Id: I7e3ca99bc9f682e7989a40155b7bbd3437b98559

Fix typo

fb64181

Change-Id: I2a2ea182a476283c5a95e66d6d013d160c3c4e89

samtstern added 2 commits April 16, 2018 11:57

Merge branch 'version-3.4.0-dev' into firestore-infinite-scroll

00a4818

Change-Id: I3f1255426bafd74f3855bd05580b6cd2cecd00a6

Typo fixes

1e02f0e

Change-Id: I882ce0d573d48f87a85d37b821ea6c60c23e675a

SUPERCILEX approved these changes Apr 16, 2018

View reviewed changes

samtstern merged commit 0f3e51e into firebase:version-3.4.0-dev Apr 16, 2018


		FirebaseUI offers two types of RecyclerView adapters for Cloud Firestore:

		* `FirestoreRecyclerAdapter` - bind a `Query` to a `RecyclerView` and respond to all real-time


		#### Paging events

		When using the `FirestorePagingAdapter` you may want to perform some action every time data

Firestore paging adapter #1178

Firestore paging adapter #1178

Conversation

samtstern commented Mar 1, 2018 • edited Loading

samtstern commented Mar 1, 2018

samtstern commented Mar 5, 2018

SUPERCILEX commented Mar 15, 2018

samtstern commented Mar 15, 2018

samtstern commented Mar 15, 2018 • edited Loading

SUPERCILEX commented Mar 18, 2018

samtstern commented Mar 19, 2018

samtstern commented Mar 29, 2018

samtstern commented Apr 11, 2018 • edited Loading

SUPERCILEX commented Apr 11, 2018

samtstern commented Apr 12, 2018

SUPERCILEX commented Apr 12, 2018

SUPERCILEX left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samtstern commented Apr 13, 2018

SUPERCILEX commented Apr 13, 2018

samtstern commented Apr 13, 2018

SUPERCILEX left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

morganchen12 commented Apr 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samtstern commented Apr 16, 2018

muammil commented Jul 17, 2018

samtstern commented Mar 1, 2018 •

edited

Loading

samtstern commented Mar 15, 2018 •

edited

Loading

samtstern commented Apr 11, 2018 •

edited

Loading

SUPERCILEX left a comment •

edited

Loading