Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setGithubButtonId to AuthMethodPickerLayout #1583

Merged
merged 2 commits into from
Feb 19, 2019
Merged

Add setGithubButtonId to AuthMethodPickerLayout #1583

merged 2 commits into from
Feb 19, 2019

Conversation

alorma
Copy link
Contributor

@alorma alorma commented Feb 19, 2019

Add method setGithubButtonId to AuthMethodPickerLayout.java so custom UI can use Github login

@alorma alorma requested a review from samtstern as a code owner February 19, 2019 14:33
@samtstern samtstern added this to the 4.3.2 milestone Feb 19, 2019
@samtstern
Copy link
Contributor

@alorma thank you! This seems like it was just a mistake, so this can go out with 4.3.2 rather than waiting for a "minor" release.

@samtstern samtstern merged commit 1e86767 into firebase:master Feb 19, 2019
@alorma
Copy link
Contributor Author

alorma commented Feb 19, 2019

Wuhu! Many thanks @samtstern

@le-kamba le-kamba mentioned this pull request May 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samtstern samtstern Awaiting requested review from samtstern

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@alorma @samtstern