fix(firebase_ui_oauth): Fix provider auth listener late init exception (

#107) * Store the provider in the state so that it doesn't get reset * Set isLoading to false in onError callback * drop tests folder --------- Co-authored-by: Andrei Lesnitsky <andrei.lesnitsky@gmail.com>
firebase · Sep 12, 2023 · 0f0fa80 · 0f0fa80
1 parent a1c1c33
commit 0f0fa80
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 17 deletions.
diff --git a/packages/firebase_ui_oauth/example/test/widget_test.dart b/packages/firebase_ui_oauth/example/test/widget_test.dart
diff --git a/packages/firebase_ui_oauth/lib/src/oauth_provider_button_base.dart b/packages/firebase_ui_oauth/lib/src/oauth_provider_button_base.dart
@@ -142,15 +142,18 @@ class OAuthProviderButtonBase extends StatefulWidget {
 
 class _OAuthProviderButtonBaseState extends State<OAuthProviderButtonBase>
     implements OAuthListener {
+  @override
+  late final OAuthProvider provider = widget.provider;
+
   double get _height => widget.size + widget._padding * 2;
   late bool isLoading = widget.isLoading;
 
   @override
   void initState() {
     super.initState();
 
-    widget.provider.auth = widget.auth ?? FirebaseAuth.instance;
-    widget.provider.authListener = this;
+    provider.auth = widget.auth ?? FirebaseAuth.instance;
+    provider.authListener = this;
   }
 
   void _signIn() {
@@ -336,6 +339,10 @@ class _OAuthProviderButtonBaseState extends State<OAuthProviderButtonBase>
 
   @override
   void onError(Object error) {
+    setState(() {
+      isLoading = false;
+    });
+
     try {
       defaultOnAuthError(provider, error);
     } on Exception catch (err) {
@@ -360,9 +367,6 @@ class _OAuthProviderButtonBaseState extends State<OAuthProviderButtonBase>
 
     super.didUpdateWidget(oldWidget);
   }
-
-  @override
-  OAuthProvider get provider => widget.provider;
 }
 
 class _ButtonContent extends StatelessWidget {