Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(database, firestore): updated default loading indicator to be platform adaptive #399

Merged
merged 2 commits into from
Sep 17, 2024
Merged

feat(database, firestore): updated default loading indicator to be platform adaptive #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4ea189
feat: updated default loading indicator to be platform adaptive
OutdatedGuy Sep 16, 2024
08b9141
Merge branch 'main' into feat/platform-indicators
russellwheatley Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/firebase_ui_database/lib/src/query_builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ class FirebaseDatabaseListView extends FirebaseDatabaseQueryBuilder {
builder: (context, snapshot, _) {
if (snapshot.isFetching) {
return loadingBuilder?.call(context) ??
const Center(child: CircularProgressIndicator());
const Center(child: CircularProgressIndicator.adaptive());
}

if (snapshot.hasError && errorBuilder != null) {
Expand Down
4 changes: 2 additions & 2 deletions packages/firebase_ui_firestore/lib/src/query_builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ class FirestoreListView<Document> extends FirestoreQueryBuilder<Document> {
builder: (context, snapshot, _) {
if (snapshot.isFetching) {
return loadingBuilder?.call(context) ??
const Center(child: CircularProgressIndicator());
const Center(child: CircularProgressIndicator.adaptive());
}

if (snapshot.hasError && errorBuilder != null) {
Expand Down Expand Up @@ -570,7 +570,7 @@ class FirestoreListView<Document> extends FirestoreQueryBuilder<Document> {
builder: (context, snapshot, _) {
if (snapshot.isFetching) {
return loadingBuilder?.call(context) ??
const Center(child: CircularProgressIndicator());
const Center(child: CircularProgressIndicator.adaptive());
}

if (snapshot.hasError && errorBuilder != null) {
Expand Down
Loading