Validate credential account

[adrianha]

• Added validation to check whether it's an external_account or service_account to fix error missing client_email caused by https://github.com/googleapis/google-auth-library-ruby/blob/main/lib/googleauth/json_key_reader.rb#L24 when using Workload Identity Federation
  • service_account –> Google::Auth::ServiceAccountCredentials
  • external_account –> Google::Auth::ExternalAccount::Credentials
• Fix tests

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[adrianha]

@tonybaroneee probably can help to review this? 🙏

[adrianha]

hi @kaibolay, could you help to publish new version that includes this diff?

[kaibolay]

@adrianha I have some additional changes queued up for a new release. Could you please test #347 and let me know if it works for you?

[adrianha]

Understood, will try it next year @kaibolay 🎉

[adrianha]

hi @kaibolay,

looks fine on my end 👍

[13:18:14]: 🔐 Authenticating with Application Default Credentials
[13:18:14]: ⌛ Uploading the APK.
[13:18:18]: 🕵️ Validating upload.
[13:18:26]: ✅ Uploaded APK successfully and created release 1.0.0 (1).
[13:18:26]: 📜 Setting release notes.
[13:18:28]: 📦 Distributing release.
[13:18:29]: 🎉 App Distribution upload finished successfully. Setting Actions.lane_context[SharedValues::FIREBASE_APP_DISTRO_RELEASE] to the uploaded release.

[kaibolay]

@adrianha Thank you. It's released now.

[adrianha]

thank you @kaibolay!

[adrianha]

hi @kaibolay, just realized that fastlane-plugin-firebase_app_distribution 0.8.0 depends on google-apis-firebaseappdistribution_v1 and google-apis-firebaseappdistribution_v1alpha, is it expected?

I got Service account impersonation failed with status 403 error after updating to 0.8.0 then it's resolved after updating other dependencies:

• aws-partitions: 1.872.0 –> 1.876.0
• aws-sdk-s3: 1.141.0 –> 1.142.0
• fastlane: 2.217.0 –> 2.218.0

[kaibolay]

hi @kaibolay, just realized that fastlane-plugin-firebase_app_distribution 0.8.0 depends on google-apis-firebaseappdistribution_v1 and google-apis-firebaseappdistribution_v1alpha, is it expected?

Yes. get_udids uses a v1alpha API.

I got Service account impersonation failed with status 403 error after updating to 0.8.0 then it's resolved after updating other dependencies:

• aws-partitions: 1.872.0 –> 1.876.0
• aws-sdk-s3: 1.141.0 –> 1.142.0
• fastlane: 2.217.0 –> 2.218.0

That's really odd. None of these are direct (or indirect) dependencies of fastlane-plugin-firebase_app_distribution.

[adrianha]

I see, maybe it's intermittent then 🤔