Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: getToken() returns existing promise to a token if one exists instead of a new token. #2648

Merged
merged 3 commits into from
Aug 1, 2024
Merged

fix: getToken() returns existing promise to a token if one exists instead of a new token. #2648

merged 3 commits into from
Aug 1, 2024

Conversation

jonathanedey
Copy link
Contributor

@jonathanedey jonathanedey commented Jul 29, 2024 •
edited
Loading

  • Concurrent calls to getToken() don't utilize cache because of a race condition which causes multiple token refreshes.
  • Fixing by returning the existing promise to a token if one is still pending instead of requesting a new one.

@jonathanedey jonathanedey linked an issue Jul 30, 2024 that may be closed by this pull request
[FR] Optimize Token Retrieval for Messaging#sendEach to Reduce Unnecessary Fetch Requests #2645
Closed
lahirumaramba
lahirumaramba approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonathanedey jonathanedey merged commit 745c22e into master Aug 1, 2024
10 checks passed
@jonathanedey jonathanedey deleted the je-get-token branch August 1, 2024 14:28
@lahirumaramba lahirumaramba mentioned this pull request Aug 22, 2024
Closed
This was referenced Aug 29, 2024
Open
Open
Open
@kenn7575 kenn7575 mentioned this pull request Aug 30, 2024
Merged
@Arjun31415 Arjun31415 mentioned this pull request Aug 30, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Aug 30, 2024
Open
@Zwiqler94 Zwiqler94 mentioned this pull request Aug 30, 2024
Open
This was referenced Aug 31, 2024
Open
Open
Open
Open
Open
Open
@Erenkrs Erenkrs mentioned this pull request Sep 7, 2024
Open
@tweiss9 tweiss9 mentioned this pull request Sep 7, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 8, 2024
Open
@IvanCastroDev IvanCastroDev mentioned this pull request Sep 8, 2024
Open
@Ocor17 Ocor17 mentioned this pull request Sep 9, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 9, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 9, 2024
Open
@IvanCastroDev IvanCastroDev mentioned this pull request Sep 10, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 11, 2024
Open
@kenn7575 kenn7575 mentioned this pull request Sep 13, 2024
Merged
@k2xl k2xl mentioned this pull request Sep 13, 2024
Open
@TartejBrothers TartejBrothers mentioned this pull request Sep 13, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request Sep 13, 2024
Open
@IvanCastroDev IvanCastroDev mentioned this pull request Sep 13, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 13, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 14, 2024
Open
@k2xl k2xl mentioned this pull request Sep 14, 2024
Open
@IvanCastroDev IvanCastroDev mentioned this pull request Sep 14, 2024
Open
This was referenced Sep 15, 2024
Open
Open
Open
@IvanCastroDev IvanCastroDev mentioned this pull request Sep 18, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 18, 2024
Open
@k2xl k2xl mentioned this pull request Sep 18, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees

@lahirumaramba lahirumaramba

Labels
release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] Optimize Token Retrieval for Messaging#sendEach to Reduce Unnecessary Fetch Requests
2 participants
@jonathanedey @lahirumaramba