Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTDB: Add startAfter + endBefore protocol support #4351

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jmwski
Copy link
Contributor

@jmwski jmwski commented Nov 22, 2022

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 22, 2022

Coverage Report 1

Affected Products

No changes between base commit (94ae2ac) and merge commit (a2d74bd).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/JRTKSegsWk.html

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2022

Unit Test Results

13 tests   - 461   13 ✔️  - 461   10s ⏱️ - 3m 44s
  4 suites  -   23     0 💤 ±    0 
  4 files    -   23     0 ±    0 

Results for commit f0cfa97. ± Comparison against base commit 94ae2ac.

This pull request removes 474 and adds 13 tests. Note that renamed tests count towards both.
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testBindsService_oAndTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNoWrappedIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNullIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_OTargetingO_highPriority
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_fallsBackToBindService
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[19]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[22]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[23]
…
com.google.firebase.database.ktx.DataSnapshotTests ‑ reified getValue works with basic types
com.google.firebase.database.ktx.DataSnapshotTests ‑ reified getValue works with custom types
com.google.firebase.database.ktx.DataSnapshotTests ‑ reified getValue works with lists types
com.google.firebase.database.ktx.DataSnapshotTests ‑ reified getValue works with maps
com.google.firebase.database.ktx.DatabaseTests ‑ Firebase#database should delegate to FirebaseDatabase#getInstance(FirebaseApp, url)
com.google.firebase.database.ktx.DatabaseTests ‑ Firebase#database should delegate to FirebaseDatabase#getInstance(url)
com.google.firebase.database.ktx.DatabaseTests ‑ FirebaseApp#database should delegate to FirebaseDatabase#getInstance(FirebaseApp)
com.google.firebase.database.ktx.DatabaseTests ‑ database should delegate to FirebaseDatabase#getInstance()
com.google.firebase.database.ktx.LibraryVersionTest ‑ library version should be registered with runtime
com.google.firebase.database.ktx.MutableDataTests ‑ reified getValue works with basic types
…

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 22, 2022

Size Report 1

Affected Products

  • firebase-database

    TypeBase (94ae2ac)Merge (a2d74bd)Diff
    aar488 kB488 kB+726 B (+0.1%)
    apk (release)1.16 MB1.16 MB+436 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0baqEGHi2w.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants