Simplify code and improve test coverage #5220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
milaGGL
changed the title
ehsannas
reviewed
Aug 4, 2023
| for (FieldFilter inequalityFilter : inequalityFilters) { | ||
| FieldPath field = inequalityFilter.getField(); | ||
| result.add(field); | ||
| List<FieldFilter> Filters = filter.getFlattenedFilters(); |
There was a problem hiding this comment.
variable name should start with lowercase (filters)
| FieldPath field = inequalityFilter.getField(); | ||
| result.add(field); | ||
| List<FieldFilter> Filters = filter.getFlattenedFilters(); | ||
| for (FieldFilter subFilter : Filters) { |
There was a problem hiding this comment.
probably easier to just do
for(FieldFilter subFilter : filter.getFlattenedFilters()) {
ehsannas
approved these changes
Aug 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port from web SDK: firebase/firebase-js-sdk#7512