Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort snapshot listeners on terminate #6136

Open
wants to merge 79 commits into
base: main
Choose a base branch
from

Conversation

tom-andersen
Copy link
Contributor

No description provided.

…actor' into tomandersen/componentProviderRefactor
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 30, 2024

Size Report 1

Affected Products

  • base

    TypeBase (08deb69)Merge (b30eaae)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)
  • firebase-firestore

    TypeBase (08deb69)Merge (b30eaae)Diff
    aar?1.44 MB? (?)
    apk (aggressive)?554 kB? (?)
    apk (release)?11.3 MB? (?)
  • protolite-well-known-types

    TypeBase (08deb69)Merge (b30eaae)Diff
    aar?1.01 MB? (?)
    apk (aggressive)?134 kB? (?)
    apk (release)?1.68 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Cpo7N93bRI.html

Copy link
Contributor

github-actions bot commented Jul 30, 2024

Unit Test Results

   186 files  ±0     186 suites  ±0   4m 37s ⏱️ -2s
1 234 tests ±0  1 218 ✔️ ±0  16 💤 ±0  0 ±0 
2 492 runs  ±0  2 460 ✔️ ±0  32 💤 ±0  0 ±0 

Results for commit 308e688. ± Comparison against base commit 08deb69.

♻️ This comment has been updated with latest results.

@tom-andersen tom-andersen assigned tom-andersen and unassigned wu-hui Jul 30, 2024
Base automatically changed from tomandersen/firestoreClientProvider to main August 12, 2024 16:34
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (b30eaae) and the base commit (08deb69) are not available.

No macrobenchmark data found for the base commit (08deb69). Analysis for the CI merge commit (b30eaae) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/rUUPe8rTSx/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants