-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dataconnect: FirebaseDataConnect.logLevel
changed to MutableStateFlow
#6586
Conversation
…dataconnect:generateApiTxtFile`
… to NOT be a breaking change
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Vertex AI Mock Responses Check
|
The public api surface has changed for the subproject firebase-dataconnect: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Coverage Report 1Affected Products
Test Logs |
Test Results 64 files - 972 64 suites - 972 1m 6s ⏱️ - 33m 19s Results for commit 7631f77. ± Comparison against base commit 2b072d9. This pull request removes 5332 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
The public api surface has changed for the subproject firebase-dataconnect: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Size Report 1Affected Products
Test Logs |
…dataconnect:generateApiTxtFile`, changing StateFlow to Flow
I'm writing an API proposal for this PR, and, in doing so, will be changing a lot of the new API surface. Please hold off reviewing for now. |
The public api surface has changed for the subproject firebase-dataconnect: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
FirebaseDataConnect.logging
addedFirebaseDataConnect.logLeve
changed to MutableStateFlow
FirebaseDataConnect.logLeve
changed to MutableStateFlow
FirebaseDataConnect.logLevel
changed to MutableStateFlow
Change the property
FirebaseDataConnect.logLevel
fromLogLevel
toMutableStateFlow<LogLevel>
.Being a MutableStateFlow enables applications to not only get and set its value, but also enables "collecting" the flow to be notified when its value changes. This can be useful, for example, to keep a UI element that reflects the log level (e.g. a "debug" checkbox) in sync with the actual log level in effect.
This PR also adds logcat messages to be emitted when the log level changes. This can be useful when examining logs after the fact to explain gaps in the logs (e.g. log level was unknowingly reduced to NONE, causing no logs to be emitted). The log messages look like this: