Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java style and AndroidManifest changes #1212

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Java style and AndroidManifest changes #1212

wants to merge 6 commits into from

Conversation

berile
Copy link
Contributor

@berile berile commented Feb 16, 2023

Description

Java style changes including renaming, updates for comments, setting classes nullable etc.
Adds taskAffinity and exported tags to integration_test/AndroidManifest.xml.

Testing

None

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@berile berile added the skip-release-notes Skip release notes check label Feb 16, 2023
@berile berile marked this pull request as ready for review February 22, 2023 20:57
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Feb 24, 2023
@github-actions
Copy link

github-actions bot commented Feb 24, 2023 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @berile on commit bc562cd
Last updated: Wed Mar 1 17:12 PST 2023
View integration test log & download artifacts

Failures Configs
auth [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/4 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@DellaBitta
Copy link
Contributor

Running Integration Tests.

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Feb 24, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 24, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels Feb 28, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 28, 2023
@berile berile added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Mar 1, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Mar 1, 2023
@berile berile added tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). and removed tests: in-progress This PR's integration tests are in progress. labels Mar 1, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Mar 1, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DellaBitta DellaBitta Awaiting requested review from DellaBitta

@jonsimantov jonsimantov Awaiting requested review from jonsimantov

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berile @DellaBitta