Add a matrix label to FTL test runs, to make sorting them easier. #1452

jonsimantov · 2023-09-19T18:06:13Z

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

Bug fix. Add the issue # below if applicable.
New feature. A non-breaking change which adds functionality.
Other, such as a build process or documentation change.

Notes

Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
Read the contribution guidelines CONTRIBUTING.md.
Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

github-actions · 2023-09-19T18:07:29Z

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit 4790c90
Last updated: Tue Sep 19 17:30 PDT 2023
View integration test log & download artifacts

Failures	Configs
firestore	[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target] (1 failed tests) QueryTest.TestCanQueryWithAndWithoutDocumentKey

Add flaky tests to go/fpl-cpp-flake-tracker

.github/workflows/integration_tests.yml

* iOS: Remove Analytics dependency from GMA integration test (#1386) * Try using CoreOnly instead of Analytics cocoapod for tests. * Update readme. * Add stub workflow for updating feature branches. * Add script to merge main into all active feature branches on a regular schedule. (#1394) * Add workflow for automatically updating feature branches weekly. * Corrected filename, and added inputs. * Remove trailing spaces. * Fix workflow. * Fix workflow name. * Fix syntax. * Fix syntax. * List remote branches instead. * Clean up script. * Untab. * Add branch list for debugging. * Untab. * Specify remote branches. * Skip second stage if no first. * Typo * Error. * List all branches. * Fix logic. * Fix spacing. * Fix output * Fix parameters. * Fix merge to use origin. * Remove debug echos. * Add git config. * Fix PR creation. * Fix PR creation. * Fix automatic push. * Increase retry. (#1402) * Add Firestore test history report (#1403) * Add --firestore flag to report Firestore history. * Add Firestore report to nightly cron job. * Remove multiline commands. * Revert "Remove multiline commands." This reverts commit 6393ae9. * Fix tabbing. * Fix packaging test detection for Firestore. * Revert "OR Query Implementation (#1335)" (#1399) This reverts commit 11332d4. * Wrap the real-time RemoteConfig test in flaky-block to automatically retry. (#1406) * Only use flaky_test on android * Update the iOS version used by FTL (#1408) * Kick off nightly packaging an hour earlier (#1409) * Fix crash on gma::Initialize without a Firebase App (#1320) Initialize Util before using Util::FIndClass. Also add an integration test for initializing gma without a firebase app. * build: pass along the CMake path (#1410) When building the subproject, we would invoke `cmake` directly, relying on the path lookup of the tool, which may or may not match the currently executing CMake. Use `CMAKE_COMMAND` which gives us the path to the current CMake executable ensuring that we use the same CMake for building the dependencies. * Add log to gsutil fetch. (#1411) * Update mobile dependencies - Thu Aug 03 2023 (#1413) * Update mobile dependencies - Thu Aug 03 2023 ### Android - com.google.firebase.firebase_bom → 32.2.2 ### iOS - Firebase/Analytics → 10.13.0 - Firebase/AppCheck → 10.13.0 - Firebase/Auth → 10.13.0 - Firebase/Core → 10.13.0 - Firebase/CoreOnly → 10.13.0 - Firebase/Crashlytics → 10.13.0 - Firebase/Database → 10.13.0 - Firebase/DynamicLinks → 10.13.0 - Firebase/Firestore → 10.13.0 - Firebase/Functions → 10.13.0 - Firebase/Installations → 10.13.0 - Firebase/Messaging → 10.13.0 - Firebase/RemoteConfig → 10.13.0 - Firebase/Storage → 10.13.0 - Google-Mobile-Ads-SDK → 10.9.0 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/5755777170). * Ensure using a Swift bridging header that supports both arm64 and x86_64. * Add release note about i386 no longer being supported. * Remove armv7 as well. --------- Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com> Co-authored-by: Jon Simantov <jsimantov@google.com> Co-authored-by: almostmatt@google.com <almostmatt@google.com> * feat(auth): Add emulator support (#1400) * add auth emulator support * fix ios number parse * update the documentation part * reduce lint warning * more lint warnings * code format * use environment to decide using emulator or not * fix a typo * add readme entry for FirebaseApp.GetApps() * update for review comment * add missing ` --------- Co-authored-by: Cynthia Jiang <cynthiajiang@google.com> * Update merge-to-main script (#1420) * Before creating the merge-main PR, branch it off main, so merge conflicts can be addressed in the branch rather than by committing to main. * Format. * Update release version number for M135, 11.4.0 (#1421) * feat(auth): enable emulator support on desktop (#1423) * add auth emulator support * fix ios number parse * update the documentation part * reduce lint warning * more lint warnings * code format * use environment to decide using emulator or not * fix a typo * add readme entry for FirebaseApp.GetApps() * update for review comment * add missing ` * make json request always do restrict json * add readme info * prepare for review * some minor tweak * code format * update review comments * update the unit test after request json change --------- Co-authored-by: Cynthia Jiang <cynthiajiang@google.com> * Internal Updates. (#1422) * Add logic to trim webp parameter from native image urls * Add Analytics function for on-device conversion (#1429) * Add Analytics function for phone number conversion * Formatting * Update analytics.h * Update analytics_test.cc * Update mobile dependencies - Tue Aug 29 2023 (#1436) * Update mobile dependencies - Tue Aug 29 2023 ### Android - com.google.android.gms.play_services_ads → 22.3.0 - com.google.firebase.firebase_bom → 32.2.3 ### iOS - Firebase/Analytics → 10.14.0 - Firebase/AppCheck → 10.14.0 - Firebase/Auth → 10.14.0 - Firebase/Core → 10.14.0 - Firebase/CoreOnly → 10.14.0 - Firebase/Crashlytics → 10.14.0 - Firebase/Database → 10.14.0 - Firebase/DynamicLinks → 10.14.0 - Firebase/Firestore → 10.14.0 - Firebase/Functions → 10.14.0 - Firebase/Installations → 10.14.0 - Firebase/Messaging → 10.14.0 - Firebase/RemoteConfig → 10.14.0 - Firebase/Storage → 10.14.0 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/6016988287). * Update query_main to use normalized_order_bys * Update query_main.cc --------- Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com> Co-authored-by: a-maurice <amaurice@google.com> * add UseEmulator api to auth (#1437) * add auth emulator support * fix ios number parse * update the documentation part * reduce lint warning * more lint warnings * code format * use environment to decide using emulator or not * fix a typo * add readme entry for FirebaseApp.GetApps() * update for review comment * add missing ` * make json request always do restrict json * add readme info * prepare for review * some minor tweak * code format * update review comments * update the unit test after request json change * remove platform logging v1 code * add useEmulator api * test with emulator * clean up for review * tweak for review * update with comments * put back necessary heartbeat blocks --------- Co-authored-by: Cynthia Jiang <cynthiajiang@google.com> * On Android, set dynamic code files to readonly (#1430) * To address an Android 14 security issue, set dex files to readonly. This follows the advice on dynamic code loading here: https://developer.android.com/about/versions/14/behavior-changes-14#safer-dynamic-code-loading * Format code. * Reorder exception check so that we cover all the spots. * Add release note. * Update iOS dependencies - Tue Sep 12 2023 (#1443) ### iOS - Firebase/Analytics → 10.15.0 - Firebase/AppCheck → 10.15.0 - Firebase/Auth → 10.15.0 - Firebase/Core → 10.15.0 - Firebase/CoreOnly → 10.15.0 - Firebase/Crashlytics → 10.15.0 - Firebase/Database → 10.15.0 - Firebase/DynamicLinks → 10.15.0 - Firebase/Firestore → 10.15.0 - Firebase/Functions → 10.15.0 - Firebase/Installations → 10.15.0 - Firebase/Messaging → 10.15.0 - Firebase/RemoteConfig → 10.15.0 - Firebase/Storage → 10.15.0 - Google-Mobile-Ads-SDK → 10.10.0 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/6164028143). Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com> * Apply unused variables patch to Flatbuffers on Android as well. (#1444) Already applied on desktop elsewhere. * Fix iOS test version from deprecate 16.5 to 16.6. (#1449) * Update Android dependencies - Mon Sep 18 2023 (#1448) * Update release version to 11.5.0. * Update readme. * Update Android dependencies - Mon Sep 18 2023 ### Android - com.google.android.gms.play_services_ads → 22.4.0 - com.google.firebase.firebase_bom → 32.3.1 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/6226059256). * Add note about GMA Android. * Revert play-services-ads to 22.3.0. --------- Co-authored-by: Jon Simantov <jsimantov@google.com> Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com> * Add a matrix label to FTL test runs, to make sorting them easier. (#1452) * Add a matrix label to FTL test runs, to make sorting them easier. * Fix label for iOS --------- Co-authored-by: Tom Andersen <tom-andersen@users.noreply.github.com> Co-authored-by: Matthew Hyndman <almostmatt@google.com> Co-authored-by: a-maurice <amaurice@google.com> Co-authored-by: Saleem Abdulrasool <compnerd@compnerd.org> Co-authored-by: firebase-workflow-trigger[bot] <80733318+firebase-workflow-trigger[bot]@users.noreply.github.com> Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com> Co-authored-by: Cynthia J <cynthiajoan@users.noreply.github.com> Co-authored-by: Cynthia Jiang <cynthiajiang@google.com> Co-authored-by: nakirekommula <126601200+nakirekommula@users.noreply.github.com>

* iOS: Remove Analytics dependency from GMA integration test (#1386) * Try using CoreOnly instead of Analytics cocoapod for tests. * Update readme. * Add stub workflow for updating feature branches. * Add script to merge main into all active feature branches on a regular schedule. (#1394) * Add workflow for automatically updating feature branches weekly. * Corrected filename, and added inputs. * Remove trailing spaces. * Fix workflow. * Fix workflow name. * Fix syntax. * Fix syntax. * List remote branches instead. * Clean up script. * Untab. * Add branch list for debugging. * Untab. * Specify remote branches. * Skip second stage if no first. * Typo * Error. * List all branches. * Fix logic. * Fix spacing. * Fix output * Fix parameters. * Fix merge to use origin. * Remove debug echos. * Add git config. * Fix PR creation. * Fix PR creation. * Fix automatic push. * Increase retry. (#1402) * Add Firestore test history report (#1403) * Add --firestore flag to report Firestore history. * Add Firestore report to nightly cron job. * Remove multiline commands. * Revert "Remove multiline commands." This reverts commit 6393ae9. * Fix tabbing. * Fix packaging test detection for Firestore. * Revert "OR Query Implementation (#1335)" (#1399) This reverts commit 11332d4. * Wrap the real-time RemoteConfig test in flaky-block to automatically retry. (#1406) * Only use flaky_test on android * Update the iOS version used by FTL (#1408) * Kick off nightly packaging an hour earlier (#1409) * Fix crash on gma::Initialize without a Firebase App (#1320) Initialize Util before using Util::FIndClass. Also add an integration test for initializing gma without a firebase app. * build: pass along the CMake path (#1410) When building the subproject, we would invoke `cmake` directly, relying on the path lookup of the tool, which may or may not match the currently executing CMake. Use `CMAKE_COMMAND` which gives us the path to the current CMake executable ensuring that we use the same CMake for building the dependencies. * Add log to gsutil fetch. (#1411) * Update mobile dependencies - Thu Aug 03 2023 (#1413) * Update mobile dependencies - Thu Aug 03 2023 ### Android - com.google.firebase.firebase_bom → 32.2.2 ### iOS - Firebase/Analytics → 10.13.0 - Firebase/AppCheck → 10.13.0 - Firebase/Auth → 10.13.0 - Firebase/Core → 10.13.0 - Firebase/CoreOnly → 10.13.0 - Firebase/Crashlytics → 10.13.0 - Firebase/Database → 10.13.0 - Firebase/DynamicLinks → 10.13.0 - Firebase/Firestore → 10.13.0 - Firebase/Functions → 10.13.0 - Firebase/Installations → 10.13.0 - Firebase/Messaging → 10.13.0 - Firebase/RemoteConfig → 10.13.0 - Firebase/Storage → 10.13.0 - Google-Mobile-Ads-SDK → 10.9.0 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/5755777170). * Ensure using a Swift bridging header that supports both arm64 and x86_64. * Add release note about i386 no longer being supported. * Remove armv7 as well. --------- Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com> Co-authored-by: Jon Simantov <jsimantov@google.com> Co-authored-by: almostmatt@google.com <almostmatt@google.com> * feat(auth): Add emulator support (#1400) * add auth emulator support * fix ios number parse * update the documentation part * reduce lint warning * more lint warnings * code format * use environment to decide using emulator or not * fix a typo * add readme entry for FirebaseApp.GetApps() * update for review comment * add missing ` --------- Co-authored-by: Cynthia Jiang <cynthiajiang@google.com> * Update merge-to-main script (#1420) * Before creating the merge-main PR, branch it off main, so merge conflicts can be addressed in the branch rather than by committing to main. * Format. * Update release version number for M135, 11.4.0 (#1421) * feat(auth): enable emulator support on desktop (#1423) * add auth emulator support * fix ios number parse * update the documentation part * reduce lint warning * more lint warnings * code format * use environment to decide using emulator or not * fix a typo * add readme entry for FirebaseApp.GetApps() * update for review comment * add missing ` * make json request always do restrict json * add readme info * prepare for review * some minor tweak * code format * update review comments * update the unit test after request json change --------- Co-authored-by: Cynthia Jiang <cynthiajiang@google.com> * Internal Updates. (#1422) * Add logic to trim webp parameter from native image urls * Add Analytics function for on-device conversion (#1429) * Add Analytics function for phone number conversion * Formatting * Update analytics.h * Update analytics_test.cc * Update mobile dependencies - Tue Aug 29 2023 (#1436) * Update mobile dependencies - Tue Aug 29 2023 ### Android - com.google.android.gms.play_services_ads → 22.3.0 - com.google.firebase.firebase_bom → 32.2.3 ### iOS - Firebase/Analytics → 10.14.0 - Firebase/AppCheck → 10.14.0 - Firebase/Auth → 10.14.0 - Firebase/Core → 10.14.0 - Firebase/CoreOnly → 10.14.0 - Firebase/Crashlytics → 10.14.0 - Firebase/Database → 10.14.0 - Firebase/DynamicLinks → 10.14.0 - Firebase/Firestore → 10.14.0 - Firebase/Functions → 10.14.0 - Firebase/Installations → 10.14.0 - Firebase/Messaging → 10.14.0 - Firebase/RemoteConfig → 10.14.0 - Firebase/Storage → 10.14.0 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/6016988287). * Update query_main to use normalized_order_bys * Update query_main.cc --------- Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com> Co-authored-by: a-maurice <amaurice@google.com> * add UseEmulator api to auth (#1437) * add auth emulator support * fix ios number parse * update the documentation part * reduce lint warning * more lint warnings * code format * use environment to decide using emulator or not * fix a typo * add readme entry for FirebaseApp.GetApps() * update for review comment * add missing ` * make json request always do restrict json * add readme info * prepare for review * some minor tweak * code format * update review comments * update the unit test after request json change * remove platform logging v1 code * add useEmulator api * test with emulator * clean up for review * tweak for review * update with comments * put back necessary heartbeat blocks --------- Co-authored-by: Cynthia Jiang <cynthiajiang@google.com> * On Android, set dynamic code files to readonly (#1430) * To address an Android 14 security issue, set dex files to readonly. This follows the advice on dynamic code loading here: https://developer.android.com/about/versions/14/behavior-changes-14#safer-dynamic-code-loading * Format code. * Reorder exception check so that we cover all the spots. * Add release note. * Update iOS dependencies - Tue Sep 12 2023 (#1443) ### iOS - Firebase/Analytics → 10.15.0 - Firebase/AppCheck → 10.15.0 - Firebase/Auth → 10.15.0 - Firebase/Core → 10.15.0 - Firebase/CoreOnly → 10.15.0 - Firebase/Crashlytics → 10.15.0 - Firebase/Database → 10.15.0 - Firebase/DynamicLinks → 10.15.0 - Firebase/Firestore → 10.15.0 - Firebase/Functions → 10.15.0 - Firebase/Installations → 10.15.0 - Firebase/Messaging → 10.15.0 - Firebase/RemoteConfig → 10.15.0 - Firebase/Storage → 10.15.0 - Google-Mobile-Ads-SDK → 10.10.0 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/6164028143). Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com> * Apply unused variables patch to Flatbuffers on Android as well. (#1444) Already applied on desktop elsewhere. * Fix iOS test version from deprecate 16.5 to 16.6. (#1449) * Update Android dependencies - Mon Sep 18 2023 (#1448) * Update release version to 11.5.0. * Update readme. * Update Android dependencies - Mon Sep 18 2023 ### Android - com.google.android.gms.play_services_ads → 22.4.0 - com.google.firebase.firebase_bom → 32.3.1 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/6226059256). * Add note about GMA Android. * Revert play-services-ads to 22.3.0. --------- Co-authored-by: Jon Simantov <jsimantov@google.com> Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com> * Add a matrix label to FTL test runs, to make sorting them easier. (#1452) * Add a matrix label to FTL test runs, to make sorting them easier. * Fix label for iOS * OR Query Implementation (#1453) * OR Query Implementation * Pretty * Add includes * Fix from PR feedback * Fix variadic parameters * Add and fix tests * Add/fix method descriptions. * Add/fix constructor and class descriptions. * Add method description to disjunction/conjunction. * Add tests. Revealed bugs to be fixed. * Fix type * Add test * Android implementation * Pretty * Pretty * Pretty * Remove const * Pretty * Fixes from code review * Release notes * Release notes * Fix Android OR Query * Release notes. * Fix release notes. * Format * Internal Updates (#1439) * Internal Updates * Revert firestore to main. * Add additional release note. * Fix bad merge output. --------- Co-authored-by: Tom Andersen <tom-andersen@users.noreply.github.com> Co-authored-by: Matthew Hyndman <almostmatt@google.com> Co-authored-by: a-maurice <amaurice@google.com> Co-authored-by: Saleem Abdulrasool <compnerd@compnerd.org> Co-authored-by: firebase-workflow-trigger[bot] <80733318+firebase-workflow-trigger[bot]@users.noreply.github.com> Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com> Co-authored-by: Cynthia J <cynthiajoan@users.noreply.github.com> Co-authored-by: Cynthia Jiang <cynthiajiang@google.com> Co-authored-by: nakirekommula <126601200+nakirekommula@users.noreply.github.com>

Add a matrix label to FTL test runs, to make sorting them easier.

43c5d5d

github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Sep 19, 2023

jonsimantov requested a review from a-maurice September 19, 2023 19:15

a-maurice reviewed Sep 19, 2023

View reviewed changes

.github/workflows/integration_tests.yml Outdated Show resolved Hide resolved

Fix label for iOS

6a90506

a-maurice approved these changes Sep 19, 2023

View reviewed changes

github-actions bot added the tests: failed This PR's integration tests failed. label Sep 19, 2023

firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 19, 2023

jonsimantov added skip-release-notes Skip release notes check and removed tests: failed This PR's integration tests failed. labels Sep 19, 2023

jonsimantov enabled auto-merge (squash) September 19, 2023 20:35

github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Sep 19, 2023

jonsimantov disabled auto-merge September 19, 2023 21:55

jonsimantov added skip-release-notes Skip release notes check and removed skip-release-notes Skip release notes check labels Sep 19, 2023

jonsimantov merged commit 4790c90 into main Sep 19, 2023
72 of 103 checks passed

github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Sep 19, 2023

firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 20, 2023

firebase locked and limited conversation to collaborators Oct 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a matrix label to FTL test runs, to make sorting them easier. #1452

Add a matrix label to FTL test runs, to make sorting them easier. #1452

jonsimantov commented Sep 19, 2023

github-actions bot commented Sep 19, 2023 •

edited

Loading

Add a matrix label to FTL test runs, to make sorting them easier. #1452

Add a matrix label to FTL test runs, to make sorting them easier. #1452

Conversation

jonsimantov commented Sep 19, 2023

Description

Testing

Type of Change

Notes

github-actions bot commented Sep 19, 2023 • edited Loading

Integration test with FLAKINESS (succeeded after retry)

github-actions bot commented Sep 19, 2023 •

edited

Loading