More of annotate endpoint property for functions #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colerogers
approved these changes
Dec 1, 2021
inlined
approved these changes
Dec 9, 2021
| options, | ||
| 'egressSettings', | ||
| 'vpcConnectorEgressSettings' | ||
| ); | ||
| endpoint.vpc = vpc; | ||
| } | ||
| convertIfPresent(endpoint, options, 'availableMemoryMb', 'memory', (mem) => { | ||
| const memoryLookup = { |
There was a problem hiding this comment.
FML that Entity has already been defined to have memoryMB yet Run now uses these friendly names (almost) directly.
taeold
added a commit
that referenced
this pull request
Jan 19, 2022
* Annotate function triggers with __endpoint property (#999) In addition to annotating function triggers with `__trigger` property, we add `__endpoint` annotation. This property will be used by the to-be-developed functions runtime to generate/declare deployment manifest that the CLI will use to deploy the function. There are lots of code duplication between the utility functions for annotating the `__trigger` and `__endpoint` properties. I didn't try to refactor the common code since I expect that we will favor `__endpoint` property in the future. * Add missing import. * More of annotate endpoint property for functions (#1009) Follows up #999 to annotate each funuctions with `__endpoint` property. Highlight of changes: * Extend unit test coverage for all v1 providers * Add `__endpoint` annotation to v1 task queue functions * Add `__requiredAPIs` annotation to task queue and scheduler functions * Explicitly set `__endpoint` to undefined in the handler namespace * No SDK-level label setting in the __endpoint annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up #999 to annotate each funuctions with
__endpointproperty.Highlight of changes:
__endpointannotation to v1 task queue functions__requiredAPIsannotation to task queue and scheduler functions__endpointannotation to functions defined in the handler namespace, similar in style to the__triggerannotation.One more follow up to expect: I'll move the responsibility of adding labels for callable/scheduled function (e.g.
deployment-callable,deployment-scheduled) from the SDK to the CLI soon.