-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds performance monitoring triggers to v2 alerts #1223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
37d60d9
to
f1e4315
Compare
* Declares a function that can handle receiving performance threshold alerts. | ||
* @param appIdOrOptsOrHandler - A specific application, options, or an event-handling function. | ||
* @param handler - Event handler which is run every time a threshold alert is received. | ||
* @returns A function that you can export and deploy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit* I think we say "Cloud Function" instead of function in remote config. I think I prefer the former. wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good catch, but I think that remote config should actually be changed. Looking at all the other alert functions (& most other v2 functions) we say 'A function...'.
I remember @egilmorez giving us guidance here a while back, but not sure which way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds Firebase Performance Monitoring triggers for performance threshold alerts to the v2 namespace.