Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IteratedDataSnapshot interface to match with firebase admin v12 #1517

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

colerogers
Copy link
Contributor

Fixes #1515 #1516

@sceee
Copy link

sceee commented Jan 29, 2024

Fixes: #1513

Copy link
Contributor

@blidd-google blidd-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, changelog entry?

@colerogers colerogers merged commit 9bda8f7 into master Feb 1, 2024
13 checks passed
@colerogers colerogers deleted the colerogers.fix-adminv12-bug branch February 1, 2024 21:45
@baraknaveh
Copy link

Thanks for fixing this!

@NathanC
Copy link

NathanC commented Feb 2, 2024

@colerogers @sceee what is the release cadence/when can I expect to be able to pick up this change?

@inlined
Copy link
Member

inlined commented Feb 7, 2024

Sorry for the delay in release. The latest version of the SDK has this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression in "Build failed with error TS2416 in firebase-functions"
6 participants