Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove infinite wrapping of withInit #1540

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Remove infinite wrapping of withInit #1540

merged 3 commits into from
Mar 19, 2024

Conversation

inlined
Copy link
Member

@inlined inlined commented Mar 19, 2024

Possible fix for #1539.

I think what's happened here is that the raw handler is captured in makeCloudFunction and repeatedly wrapped during the boilerplate code that invokes the handler. This causes an unbounded call stack that eventually causes a crash. To fix, we wrap once during makeCloudFunction and pass the wrapped function to the lambda that actually gets executed.

@inlined inlined merged commit ad6cd43 into master Mar 19, 2024
13 checks passed
@inlined inlined deleted the inlined.on-init-fix branch March 19, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants