Use await import instead of require for functions modules that contain top-level awaits #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n top-level awaits
|
Can we add a test case in https://github.com/firebase/firebase-functions/tree/master/scripts/bin-test/sources? We will also want to expand our text matrics to test against node 22 so we can actually make sure this issue is fixed: |
…led (#1650) * Add support for an authPolicy that returns Permission Denied when failed * Formatter * Changelog * remove ignorant comment
* Update streaming callable API * Fix linter error * Stream type defaults to unknown * Changelog * Format fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firebase/firebase-tools#8054 surfaced an issue in which functions containing top-level awaits threw ERR_REQUIRE_ASYNC_MODULE errors during functions discovery, due to changes in Node 22.12 (https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V22.md#requireesm-is-now-enabled-by-default).
Previously, ES modules containing top-level awaits would be imported via awaiting an import() instead of require() in a catch block after the require failed. Extending the catch conditions to cover this new error should deal with current regressions, while we consider if we need to do any other work.
Fixes firebase/firebase-tools#8054