New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api Diff Report CI #11236

Merged

sunmou99 merged 27 commits into master from api-diff-ci

May 10, 2023

Contributor

sunmou99 commented May 5, 2023 •

edited

Loading

This is the workflow that detects API changes and generate API Diff Report and add public-api-change label.
New commit will trigger a new workflow run and cancel previous workflow.

There are 3 types of report:

⏳ Detecting API diff in progress... (Meaning workflow in progress. I do see github API that could hide the comment😔)
✅ No API Diff detected
Apple API Diff Report + diff detail. Plus label public-api-change

The report is informative and the workflow won't block the merge.
The workflow is GREEN if an report been created (No API diff or API diff).
The workflow is RED only then the workflow itself has an issue.

sunmou99 added 4 commits

May 5, 2023 15:57


          api diff report CI

0750a08


          fix ci


          fix ci

9fef44c


          fix ci

302c9c3

firebase deleted a comment from github-actions bot


          fix ci

c570210

Contributor

github-actions bot commented May 5, 2023 •

edited

Loading

✅ No API diff detected

Commit: 565614a
Last updated: Wed May 10 11:37 PDT 2023
View workflow logs & download artifacts

sunmou99 added 2 commits

May 5, 2023 16:19


          fix typo

ca61e51


          fix format

7c6e795

sunmou99 marked this pull request as ready for review

May 5, 2023 23:25

sunmou99 requested review from morganchen12, yifanyang and ncooke3

May 5, 2023 23:25


          fix format

16a5b01

yifanyang reviewed

View reviewed changes

Contributor

yifanyang left a comment

Left a few comments. Let me know if you want to discuss about them offline.

.github/workflows/api_report.yml Outdated Show resolved Hide resolved

.github/workflows/api_report.yml Outdated Show resolved Hide resolved

.github/workflows/api_report.yml Outdated Show resolved Hide resolved

.github/workflows/api_report.yml Outdated Show resolved Hide resolved

.github/workflows/api_report.yml Outdated Show resolved Hide resolved

scripts/api_diff_report/api_diff_report.py Outdated Show resolved Hide resolved

scripts/api_diff_report/api_diff_report.py Show resolved Hide resolved

scripts/api_diff_report/pr_commenter.py Show resolved Hide resolved

scripts/api_diff_report/pr_commenter.py Show resolved Hide resolved

scripts/api_diff_report/pr_commenter.py Outdated Show resolved Hide resolved

sunmou99 added 2 commits

May 9, 2023 14:11


          fix based on comments

88a96ed


          test api changes

62946f3

google-oss-bot added api: appcheck public-api-change labels


          test api changes

979fa3b

github-actions bot removed the public-api-change label

google-oss-bot added the public-api-change label


          remove copy

6f4d537

github-actions bot removed the public-api-change label

google-oss-bot added the public-api-change label


          revert copy

466b48b

github-actions bot removed the public-api-change label

google-oss-bot added the public-api-change label


          test git env in env

a838924

github-actions bot removed the public-api-change label


          test checkout path

318fb08

github-actions bot removed the public-api-change label

google-oss-bot added the public-api-change label


          test checkout path

b5885ac

github-actions bot removed the public-api-change label

google-oss-bot added the public-api-change label


          test checkout path

7753e04

github-actions bot removed the public-api-change label

google-oss-bot added the public-api-change label

sunmou99 added 2 commits

May 9, 2023 16:43


          test checkout path

f3bb261


          test checkout path

d94b820

github-actions bot removed the public-api-change label

google-oss-bot added the public-api-change label


          test checkout path

eec8f55

github-actions bot added public-api-change and removed public-api-change labels


          revert code and copy script again

4a2fd32

github-actions bot removed the public-api-change label

google-oss-bot added the public-api-change label


          revert code and copy script again

404f2c1

github-actions bot removed the public-api-change label


          revert code and copy script again

9e52e2d

ncooke3 reviewed

View reviewed changes

.github/workflows/api_diff_report.yml Show resolved Hide resolved

.github/workflows/api_diff_report.yml Outdated Show resolved Hide resolved

scripts/api_diff_report/pr_commenter.py Show resolved Hide resolved

scripts/api_diff_report/pr_commenter.py Outdated Show resolved Hide resolved

scripts/api_diff_report/prerequisite.sh Show resolved Hide resolved


          fix based on comments

494fe50

sunmou99 requested review from ncooke3 and yifanyang

May 10, 2023 19:51

ncooke3 approved these changes

View reviewed changes

sunmou99 merged commit ecd4035 into master

sunmou99 deleted the api-diff-ci branch

May 10, 2023 22:04

firebase locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels