-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade cmake build to grpc 162 #12417
Conversation
Coverage Report 1Affected Products
Test Logs |
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
[needless to say] I didn't review any file that has
// Generated by the protocol buffer compiler. DO NOT EDIT!
at the top, and assumed the changes were auto-generated.
Should be good to merge now since we're on track to land SPM support for M145. |
I meant the comment above for #12398 |
….24.0" (#1007) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [firebase/firebase-ios-sdk](https://github.com/firebase/firebase-ios-sdk) | minor | `from: "10.23.1"` -> `from: "10.24.0"` | --- ### Release Notes <details> <summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary> ### [`v10.24.0`](https://github.com/firebase/firebase-ios-sdk/releases/tag/10.24.0): Firebase Apple 10.24.0 [Compare Source](https://github.com/firebase/firebase-ios-sdk/compare/10.23.1...10.24.0) The Firebase Apple SDK (10.24.0) is now available. For more details, see the [Firebase Apple SDK release notes.](https://firebase.google.com/support/release-notes/ios#10.24.0) To install this SDK, see [Add Firebase to your project.](https://firebase.google.com/docs/ios/setup) #### What's Changed - Remove calls to fstat in crashlytics by [@​volantwish](https://github.com/volantwish) in [https://github.com/firebase/firebase-ios-sdk/pull/12531](https://github.com/firebase/firebase-ios-sdk/pull/12531) - fix unit tests by [@​themiswang](https://github.com/themiswang) in [https://github.com/firebase/firebase-ios-sdk/pull/12553](https://github.com/firebase/firebase-ios-sdk/pull/12553) - \[Release] Add release note for signed artifact changes by [@​ncooke3](https://github.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12558](https://github.com/firebase/firebase-ios-sdk/pull/12558) - Fix typo by [@​paulb777](https://github.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12565](https://github.com/firebase/firebase-ios-sdk/pull/12565) - \[Firestore] Add a check to ensure FirestoreInternal has same public headers as Firestore by [@​ncooke3](https://github.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12575](https://github.com/firebase/firebase-ios-sdk/pull/12575) - Carthage 10.23.0 by [@​paulb777](https://github.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12588](https://github.com/firebase/firebase-ios-sdk/pull/12588) - Initial CI for visionOS by [@​paulb777](https://github.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12578](https://github.com/firebase/firebase-ios-sdk/pull/12578) - Upgrade cmake build to grpc 162 by [@​wu-hui](https://github.com/wu-hui) in [https://github.com/firebase/firebase-ios-sdk/pull/12417](https://github.com/firebase/firebase-ios-sdk/pull/12417) - More visionOS CI by [@​paulb777](https://github.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12608](https://github.com/firebase/firebase-ios-sdk/pull/12608) - Update versions for Release 10.24.0 by [@​paulb777](https://github.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12594](https://github.com/firebase/firebase-ios-sdk/pull/12594) - \[Release Tooling] Update XCFramework structure by [@​ncooke3](https://github.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12595](https://github.com/firebase/firebase-ios-sdk/pull/12595) - \[Docs] Update `FirebaseCore/CHANGELOG.md` with correct issue # by [@​ncooke3](https://github.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12639](https://github.com/firebase/firebase-ios-sdk/pull/12639) - Adds putFileHandle and putFileHandleAsync by [@​mattcomi](https://github.com/mattcomi) in [https://github.com/firebase/firebase-ios-sdk/pull/12580](https://github.com/firebase/firebase-ios-sdk/pull/12580) - \[CocoaPods] Lock FirestoreInternal version to Firestore by [@​paulb777](https://github.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12654](https://github.com/firebase/firebase-ios-sdk/pull/12654) - Merge 10.23.1 by [@​paulb777](https://github.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12655](https://github.com/firebase/firebase-ios-sdk/pull/12655) - \[Crashlytics] Fix missing Swift header error by [@​ncooke3](https://github.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12659](https://github.com/firebase/firebase-ios-sdk/pull/12659) - Move MIEQ to composite index tests by [@​milaGGL](https://github.com/milaGGL) in [https://github.com/firebase/firebase-ios-sdk/pull/12416](https://github.com/firebase/firebase-ios-sdk/pull/12416) - feat: add basic support to build frameworks and zip them for the Apple Watch by [@​jasesuperhero](https://github.com/jasesuperhero) in [https://github.com/firebase/firebase-ios-sdk/pull/12624](https://github.com/firebase/firebase-ios-sdk/pull/12624) - Release note for watchOS zip/Carthage by [@​paulb777](https://github.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12670](https://github.com/firebase/firebase-ios-sdk/pull/12670) - \[Crashlytics] Remove mach_absolute_time usages by [@​paulb777](https://github.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12664](https://github.com/firebase/firebase-ios-sdk/pull/12664) - Update to SwiftFormat 0.53.5 by [@​paulb777](https://github.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12665](https://github.com/firebase/firebase-ios-sdk/pull/12665) - Fix typo: Timout -> Timeout by [@​Jager-yoo](https://github.com/Jager-yoo) in [https://github.com/firebase/firebase-ios-sdk/pull/12672](https://github.com/firebase/firebase-ios-sdk/pull/12672) - \[Crashlytics] Regenerate privacy manifest by [@​ncooke3](https://github.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12675](https://github.com/firebase/firebase-ios-sdk/pull/12675) - \[Release] Version changelog entries for 10.24.0 by [@​ncooke3](https://github.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12677](https://github.com/firebase/firebase-ios-sdk/pull/12677) - \[Release Tooling] Fix METADATA.md regression introduced in [#​12595](https://github.com/firebase/firebase-ios-sdk/issues/12595) by [@​ncooke3](https://github.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12661](https://github.com/firebase/firebase-ios-sdk/pull/12661) - Analytics 10.24.0 by [@​tsunghung](https://github.com/tsunghung) in [https://github.com/firebase/firebase-ios-sdk/pull/12693](https://github.com/firebase/firebase-ios-sdk/pull/12693) - \[Release] Update binary SPM Firestore distro for 10.24.0 by [@​ncooke3](https://github.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12708](https://github.com/firebase/firebase-ios-sdk/pull/12708) - \[Release] Update Firestore's binary deps in Package.swift by [@​ncooke3](https://github.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12709](https://github.com/firebase/firebase-ios-sdk/pull/12709) #### New Contributors - [@​volantwish](https://github.com/volantwish) made their first contribution in [https://github.com/firebase/firebase-ios-sdk/pull/12531](https://github.com/firebase/firebase-ios-sdk/pull/12531) - [@​mattcomi](https://github.com/mattcomi) made their first contribution in [https://github.com/firebase/firebase-ios-sdk/pull/12580](https://github.com/firebase/firebase-ios-sdk/pull/12580) - [@​jasesuperhero](https://github.com/jasesuperhero) made their first contribution in [https://github.com/firebase/firebase-ios-sdk/pull/12624](https://github.com/firebase/firebase-ios-sdk/pull/12624) - [@​Jager-yoo](https://github.com/Jager-yoo) made their first contribution in [https://github.com/firebase/firebase-ios-sdk/pull/12672](https://github.com/firebase/firebase-ios-sdk/pull/12672) **Full Changelog**: firebase/firebase-ios-sdk@10.23.1...10.24.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Note: we need to change the cocopods files for the test projects because newer version of grpc generate the pb.cc files that require updating the cocoapods configurations. It only impact how we run our tests through xcodebuild, and the actual SDK is not impacted.
There are other various small changes needed to make everything build, i have left comments to call them out. The majority of the changes are coming from generated pb.cc files as a result of protobufcpp upgrade.