Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Firestore] Improve logging in scripts/check_firestore_symbols.sh #12535

Merged
merged 1 commit into from
Mar 12, 2024
Merged

[Firestore] Improve logging in scripts/check_firestore_symbols.sh #12535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/check_firestore_symbols.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,14 +153,17 @@ nm ~/Library/Developer/Xcode/DerivedData/TestPkg-ObjC/Build/Products/Debug/TestP
# return exit code 1, which will cause the set pipefail to terminate execution.
# To avoid this, `|| true` ensures the exit code always indicates success.
DIFF=$(
git diff --no-index \
git diff --no-index --output-indicator-new="?" \
objc_symbols_without_linker_flag.txt \
objc_symbols_with_linker_flag.txt \
|| true
)
if [[ -n "$DIFF" ]]; then
echo "Failure: Unlinked Objective-C symbols have been detected:"
echo "$DIFF"
echo -n "💡 To fix, follow the process shown in "
echo -n "https://github.com/firebase/firebase-ios-sdk/pull/12534 for the "
echo "above symbols that are prefixed with ?"
exit 1
else
echo "Success: No unlinked Objective-C symbols have been detected."
Expand Down
Loading