New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Firestore build warnings #12536

Merged

ncooke3 merged 1 commit into main from cheryllin/warningFix

Mar 12, 2024

Contributor

cherylEnkidu commented Mar 12, 2024 •

edited

Loading

#no-changelog


          fix size_t

13725ae

cherylEnkidu mentioned this pull request

Firestore build warnings #12516

Closed

google-oss-bot added the api: firestore label

google-oss-bot commented Mar 12, 2024

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

google-oss-bot commented Mar 12, 2024

Coverage Report ¹

Affected Products

`FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework`

Overall coverage changed from 88.22% (3e7aa39) to 88.19% (2155120) by -0.02%.

Filename	Base (`3e7aa39`)	Merge (`2155120`)	Diff
leveldb_key.cc	98.63%	98.14%	-0.49%
leveldb_mutation_queue.cc	93.56%	92.42%	-1.14%
ordered_code.cc	93.90%	94.39%	+0.49%
task.cc	96.52%	94.78%	-1.74%
write_stream.cc	91.55%	94.37%	+2.82%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/N7rPhhCRJH.html

paulb777 approved these changes

View reviewed changes

Member

paulb777 left a comment

Thanks!

ncooke3 linked an issue

that may be closed by this pull request

Firestore build warnings #12516

Closed

ncooke3 merged commit 455e7d5 into main

49 checks passed

ncooke3 deleted the cheryllin/warningFix branch

March 12, 2024 22:56

cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager


          chore(deps): update dependency firebase/firebase-ios-sdk to from: "10…

8cead7d

….23.1" (#948)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[firebase/firebase-ios-sdk](https://github.com/firebase/firebase-ios-sdk)
| minor | `from: "10.21.0"` -> `from: "10.23.1"` |

---

### Release Notes

<details>
<summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary>

###
[`v10.23.1`](https://github.com/firebase/firebase-ios-sdk/releases/tag/10.23.1)

[Compare
Source](https://github.com/firebase/firebase-ios-sdk/compare/10.23.0...10.23.1)

The Firebase Apple SDK (10.23.1) is now available.

This release is only available for CocoaPods and Swift Package Manager
and only changes Firebase Analytics.

See details at [Firebase Apple SDK release
notes.](https://firebase.google.com/support/release-notes/ios#10.23.1)

#### What's Changed

- \[Release] Update Package.swift for 10.23.1 patch by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12644](https://github.com/firebase/firebase-ios-sdk/pull/12644)
- Analytics 10.23.1 by [@&#8203;htcgh](https://github.com/htcgh) in
[https://github.com/firebase/firebase-ios-sdk/pull/12648](https://github.com/firebase/firebase-ios-sdk/pull/12648)
- 10.23.1 podspec updates by
[@&#8203;paulb777](https://github.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12647](https://github.com/firebase/firebase-ios-sdk/pull/12647)
- Tweak release note by
[@&#8203;paulb777](https://github.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12649](https://github.com/firebase/firebase-ios-sdk/pull/12649)

**Full Changelog**:
firebase/firebase-ios-sdk@10.23.0...10.23.1

###
[`v10.23.0`](https://github.com/firebase/firebase-ios-sdk/releases/tag/10.23.0)

[Compare
Source](https://github.com/firebase/firebase-ios-sdk/compare/10.22.1...10.23.0)

The Firebase Apple SDK (10.23.0) is now available. For more details, see
the [Firebase Apple SDK release
notes.](https://firebase.google.com/support/release-notes/ios#10.23.0)

To install this SDK, see [Add Firebase to your
project.](https://firebase.google.com/docs/ios/setup)

#### What's Changed

- \[Release] Update versions for Release 10.23.0 by
[@&#8203;andrewheard](https://github.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/12467](https://github.com/firebase/firebase-ios-sdk/pull/12467)
- Add API tests for hashed email and phone number by
[@&#8203;tsunghung](https://github.com/tsunghung) in
[https://github.com/firebase/firebase-ios-sdk/pull/12469](https://github.com/firebase/firebase-ios-sdk/pull/12469)
- Update upload-symbols to 13.7 by
[@&#8203;themiswang](https://github.com/themiswang) in
[https://github.com/firebase/firebase-ios-sdk/pull/12471](https://github.com/firebase/firebase-ios-sdk/pull/12471)
- Analytics 10.22.1 by
[@&#8203;tsunghung](https://github.com/tsunghung) in
[https://github.com/firebase/firebase-ios-sdk/pull/12482](https://github.com/firebase/firebase-ios-sdk/pull/12482)
- Upgrade `clang-format` to v18 by
[@&#8203;andrewheard](https://github.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/12483](https://github.com/firebase/firebase-ios-sdk/pull/12483)
- \[Release] Add patch note for 10.22.1 by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12490](https://github.com/firebase/firebase-ios-sdk/pull/12490)
- Restore 10.23.0 versions to main after 10.22.1 by
[@&#8203;paulb777](https://github.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12497](https://github.com/firebase/firebase-ios-sdk/pull/12497)
- Patch abseil-cpp to ignore deprecated errors in new Xcode. by
[@&#8203;jonsimantov](https://github.com/jonsimantov) in
[https://github.com/firebase/firebase-ios-sdk/pull/12498](https://github.com/firebase/firebase-ios-sdk/pull/12498)
- Fix CI breakage from recent merge by
[@&#8203;paulb777](https://github.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12504](https://github.com/firebase/firebase-ios-sdk/pull/12504)
- Resolved warning no rule to process file 'PrivacyInfo.xcprivacy' of
type 'text.xml' with CocoaPods by
[@&#8203;HikaruSato](https://github.com/HikaruSato) in
[https://github.com/firebase/firebase-ios-sdk/pull/12513](https://github.com/firebase/firebase-ios-sdk/pull/12513)
- Upgrade grpc to 1.62 for cocoapods by
[@&#8203;wu-hui](https://github.com/wu-hui) in
[https://github.com/firebase/firebase-ios-sdk/pull/12398](https://github.com/firebase/firebase-ios-sdk/pull/12398)
- Snapshot listener source from cache by
[@&#8203;milaGGL](https://github.com/milaGGL) in
[https://github.com/firebase/firebase-ios-sdk/pull/12370](https://github.com/firebase/firebase-ios-sdk/pull/12370)
- \[Rollouts] Feature rollouts merge to main by
[@&#8203;themiswang](https://github.com/themiswang) in
[https://github.com/firebase/firebase-ios-sdk/pull/12410](https://github.com/firebase/firebase-ios-sdk/pull/12410)
- \[spm] Update grpc to 1.62.3 by
[@&#8203;paulb777](https://github.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12520](https://github.com/firebase/firebase-ios-sdk/pull/12520)
- \[Release Tooling] Copy over macOS/macCatalyst plists by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12517](https://github.com/firebase/firebase-ios-sdk/pull/12517)
- NOTICES Change by
[@&#8203;github-actions](https://github.com/github-actions) in
[https://github.com/firebase/firebase-ios-sdk/pull/12524](https://github.com/firebase/firebase-ios-sdk/pull/12524)
- Changelog updates for 10.23.0 by
[@&#8203;paulb777](https://github.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12533](https://github.com/firebase/firebase-ios-sdk/pull/12533)
- \[Firestore] Improve logging in scripts/check_firestore_symbols.sh by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12535](https://github.com/firebase/firebase-ios-sdk/pull/12535)
- \[Firestore] Add unlinked symbol introduced in
[#&#8203;12370](https://github.com/firebase/firebase-ios-sdk/issues/12370)
by [@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12534](https://github.com/firebase/firebase-ios-sdk/pull/12534)
- \[Firestore] Re-export public header added in
[#&#8203;12370](https://github.com/firebase/firebase-ios-sdk/issues/12370)
by [@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12537](https://github.com/firebase/firebase-ios-sdk/pull/12537)
- \[Firestore] Bump dependency ranges for Firestore's binary SPM distro
by [@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12538](https://github.com/firebase/firebase-ios-sdk/pull/12538)
- Fix Firestore build warnings by
[@&#8203;cherylEnkidu](https://github.com/cherylEnkidu) in
[https://github.com/firebase/firebase-ios-sdk/pull/12536](https://github.com/firebase/firebase-ios-sdk/pull/12536)
- Analytics 10.23.0 by [@&#8203;htcgh](https://github.com/htcgh) in
[https://github.com/firebase/firebase-ios-sdk/pull/12539](https://github.com/firebase/firebase-ios-sdk/pull/12539)
- \[Release] Update FirebaseFirestoreInternal checksum by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12545](https://github.com/firebase/firebase-ios-sdk/pull/12545)
- \[Release] Re-spin FST with signed artifact by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12549](https://github.com/firebase/firebase-ios-sdk/pull/12549)

#### New Contributors

- [@&#8203;HikaruSato](https://github.com/HikaruSato) made their first
contribution in
[https://github.com/firebase/firebase-ios-sdk/pull/12513](https://github.com/firebase/firebase-ios-sdk/pull/12513)

**Full Changelog**:
firebase/firebase-ios-sdk@10.22.1...10.23.0

###
[`v10.22.1`](https://github.com/firebase/firebase-ios-sdk/releases/tag/10.22.1):
Firebase Apple 10.22.1

[Compare
Source](https://github.com/firebase/firebase-ios-sdk/compare/10.22.0...10.22.1)

The Firebase Apple SDK (10.22.1) is now available. For more details, see
the [Firebase Apple SDK release
notes.](https://firebase.google.com/support/release-notes/ios#10.22.1)

To install this SDK, see [Add Firebase to your
project.](https://firebase.google.com/docs/ios/setup)

###
[`v10.22.0`](https://github.com/firebase/firebase-ios-sdk/releases/tag/10.22.0):
Firebase Apple 10.22.0

[Compare
Source](https://github.com/firebase/firebase-ios-sdk/compare/10.21.0...10.22.0)

The Firebase Apple SDK (10.22.0) is now available. For more details, see
the [Firebase Apple SDK release
notes](https://firebase.google.com/support/release-notes/ios#10.22.0).

To install this SDK, see [Add Firebase to your
project](https://firebase.google.com/docs/ios/setup).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>

firebase locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels