Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FirebaseAppCheck module from Vertex AI sample app #12754

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Remove FirebaseAppCheck module from Vertex AI sample app #12754

merged 1 commit into from
Apr 11, 2024

Conversation

andrewheard
Copy link
Contributor

  • Removed Firebase App Check from the list of frameworks installed by default in the Vertex AI sample
    • It is not required to use the sample and emits a DeviceCheck (default provider) configuration error if not configured
  • Added a recommendation comment to use App Check where we call FirebaseApp.configure()

#no-changelog

@andrewheard andrewheard requested a review from paulb777 April 11, 2024 18:23
@andrewheard andrewheard merged commit fc0f8a4 into vertex-ai Apr 11, 2024
42 checks passed
@andrewheard andrewheard deleted the ah/vertex-app-check-sample branch April 11, 2024 18:51
andrewheard added a commit that referenced this pull request May 1, 2024
@andrewheard
Remove FirebaseAppCheck module from Vertex AI sample app (#12754)
d535198
@firebase firebase locked and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewheard @paulb777