Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick CI fixes into vertex-ai branch #12862

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Cherrypick CI fixes into vertex-ai branch #12862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe244ed
Disable quickstart CI that doesn't work with Xcode 15 (#12846)
paulb777 Apr 24, 2024
63b74c8
Disable failing ObjC Performance quickstart on CI (#12853)
andrewheard Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
119 changes: 60 additions & 59 deletions .github/workflows/functions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,68 +110,69 @@ jobs:
- name: Unit Tests
run: scripts/third_party/travis/retry.sh ./scripts/build.sh FirebaseFunctionsUnit ${{ matrix.target }} spm

quickstart:
# Don't run on private repo unless it is a PR.
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
env:
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
LEGACY: true
# TODO: Move to macos-14 and Xcode 15. The legacy quickstart uses material which doesn't build on Xcode 15.
runs-on: macos-12
# TODO: Move to macos-14 and Xcode 15. The legacy quickstart uses material which doesn't build on Xcode 15.
# quickstart:
# # Don't run on private repo unless it is a PR.
# if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
# env:
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
# signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
# LEGACY: true
# # TODO: Move to macos-14 and Xcode 15. The legacy quickstart uses material which doesn't build on Xcode 15.
# runs-on: macos-12

steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
- name: Setup quickstart
run: scripts/setup_quickstart.sh functions
- name: install secret googleservice-info.plist
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-functions.plist.gpg \
quickstart-ios/functions/GoogleService-Info.plist "$plist_secret"
- name: Setup custom URL scheme
run: sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
- name: Test objc quickstart
run: ([ -z $plist_secret ] ||
scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true)
- name: Test swift quickstart
run: ([ -z $plist_secret ] ||
scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true swift)
# steps:
# - uses: actions/checkout@v4
# - uses: ruby/setup-ruby@v1
# - name: Setup quickstart
# run: scripts/setup_quickstart.sh functions
# - name: install secret googleservice-info.plist
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-functions.plist.gpg \
# quickstart-ios/functions/GoogleService-Info.plist "$plist_secret"
# - name: Setup custom URL scheme
# run: sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
# - name: Test objc quickstart
# run: ([ -z $plist_secret ] ||
# scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true)
# - name: Test swift quickstart
# run: ([ -z $plist_secret ] ||
# scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true swift)

quickstart-ftl-cron-only:
# Don't run on private repo
if: github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule'
env:
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
LEGACY: true
# TODO: Move to macos-14 and Xcode 15. The legacy quickstart uses material which doesn't build on Xcode 15.
runs-on: macos-12
# quickstart-ftl-cron-only:
# # Don't run on private repo
# if: github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule'
# env:
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
# signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
# LEGACY: true
# # TODO: Move to macos-14 and Xcode 15. The legacy quickstart uses material which doesn't build on Xcode 15.
# runs-on: macos-12

steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
- uses: actions/setup-python@v4
with:
python-version: '3.11'
- name: Setup quickstart
run: scripts/setup_quickstart.sh functions
- name: install secret googleservice-info.plist
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-functions.plist.gpg \
quickstart-ios/functions/GoogleService-Info.plist "$plist_secret"
- name: Setup custom URL scheme
run: sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
- name: Build objc quickstart
run: ([ -z $plist_secret ] ||
scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Functions)
- name: Build swift quickstart
run: ([ -z $plist_secret ] ||
scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Functions swift)
- id: ftl_test
uses: FirebaseExtended/github-actions/firebase-test-lab@v1.4
with:
credentials_json: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_CREDENTIALS }}
testapp_dir: quickstart-ios/build-for-testing
test_type: "xctest"
# steps:
# - uses: actions/checkout@v4
# - uses: ruby/setup-ruby@v1
# - uses: actions/setup-python@v4
# with:
# python-version: '3.11'
# - name: Setup quickstart
# run: scripts/setup_quickstart.sh functions
# - name: install secret googleservice-info.plist
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-functions.plist.gpg \
# quickstart-ios/functions/GoogleService-Info.plist "$plist_secret"
# - name: Setup custom URL scheme
# run: sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
# - name: Build objc quickstart
# run: ([ -z $plist_secret ] ||
# scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Functions)
# - name: Build swift quickstart
# run: ([ -z $plist_secret ] ||
# scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Functions swift)
# - id: ftl_test
# uses: FirebaseExtended/github-actions/firebase-test-lab@v1.4
# with:
# credentials_json: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_CREDENTIALS }}
# testapp_dir: quickstart-ios/build-for-testing
# test_type: "xctest"

functions-cron-only:
# Don't run on private repo.
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/performance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
env:
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
runs-on: macos-12 # TODO: the legacy ObjC quickstarts don't run with Xcode 15.
runs-on: macos-14
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
Expand All @@ -90,8 +90,9 @@ jobs:
quickstart-ios/performance/GoogleService-Info.plist "$plist_secret"
- name: Test swift quickstart
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Performance true swift)
- name: Test objc quickstart
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Performance true)
# TODO: The legacy ObjC quickstarts don't run with Xcode 15, re-able if we get these working.
# - name: Test objc quickstart
# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Performance true)

quickstart-ftl-cron-only:
if: github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule'
Expand Down
81 changes: 41 additions & 40 deletions .github/workflows/prerelease.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,47 +434,48 @@ jobs:
name: quickstart_artifacts_firestore
path: quickstart-ios/

functions_quickstart:
# TODO: The functions quickstart uses Material which isn't supported by Xcode 15
#functions_quickstart:
# Don't run on private repo unless it is a PR.
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'workflow_dispatch'
needs: buildup_SpecsTesting_repo
env:
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
bot_token_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
testing_repo_dir: "/tmp/test/"
testing_repo: "firebase-ios-sdk"
LEGACY: true
# TODO: The functions quickstart uses Material which isn't supported by Xcode 15
runs-on: macos-12
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
- name: Get token
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/bot-access.txt.gpg \
bot-access.txt "$bot_token_secret"
- name: Setup testing repo and quickstart
run: |
botaccess=`cat bot-access.txt`
BOT_TOKEN="${botaccess}" scripts/setup_quickstart.sh functions prerelease_testing
- name: install secret googleservice-info.plist
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-functions.plist.gpg \
quickstart-ios/functions/GoogleService-Info.plist "$plist_secret"
- name: Setup custom URL scheme
run: sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
- name: Test objc quickstart
run: ([ -z $plist_secret ] ||
scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true)
- name: Test swift quickstart
run: ([ -z $plist_secret ] ||
scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true swift)
- name: Remove data before upload
run: scripts/remove_data.sh functions release_testing
- uses: actions/upload-artifact@v4
if: ${{ failure() }}
with:
name: quickstart_artifacts_functions
path: quickstart-ios/
# if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'workflow_dispatch'
# needs: buildup_SpecsTesting_repo
# env:
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
# signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
# bot_token_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
# testing_repo_dir: "/tmp/test/"
# testing_repo: "firebase-ios-sdk"
# LEGACY: true
# # TODO: The functions quickstart uses Material which isn't supported by Xcode 15
# runs-on: macos-12
# steps:
# - uses: actions/checkout@v4
# - uses: ruby/setup-ruby@v1
# - name: Get token
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/bot-access.txt.gpg \
# bot-access.txt "$bot_token_secret"
# - name: Setup testing repo and quickstart
# run: |
# botaccess=`cat bot-access.txt`
# BOT_TOKEN="${botaccess}" scripts/setup_quickstart.sh functions prerelease_testing
# - name: install secret googleservice-info.plist
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-functions.plist.gpg \
# quickstart-ios/functions/GoogleService-Info.plist "$plist_secret"
# - name: Setup custom URL scheme
# run: sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
# - name: Test objc quickstart
# run: ([ -z $plist_secret ] ||
# scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true)
# - name: Test swift quickstart
# run: ([ -z $plist_secret ] ||
# scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true swift)
# - name: Remove data before upload
# run: scripts/remove_data.sh functions release_testing
# - uses: actions/upload-artifact@v4
# if: ${{ failure() }}
# with:
# name: quickstart_artifacts_functions
# path: quickstart-ios/

inappmessaging_quickstart:
# Don't run on private repo unless it is a PR.
Expand Down
82 changes: 41 additions & 41 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,47 +385,47 @@ jobs:
name: quickstart_artifacts_firestore
path: quickstart-ios/

functions_quickstart:
# Don't run on private repo unless it is a PR.
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch'
needs: buildup_SpecsTesting_repo
env:
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
bot_token_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
testing_repo_dir: "/tmp/test/"
testing_repo: "firebase-ios-sdk"
LEGACY: true
# TODO: The functions quickstart uses Material which isn't supported by Xcode 15
runs-on: macos-12
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
- name: Get token
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/bot-access.txt.gpg \
bot-access.txt "$bot_token_secret"
- name: Setup testing repo and quickstart
run: |
botaccess=`cat bot-access.txt`
BOT_TOKEN="${botaccess}" scripts/setup_quickstart.sh functions nightly_release_testing
- name: install secret googleservice-info.plist
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-functions.plist.gpg \
quickstart-ios/functions/GoogleService-Info.plist "$plist_secret"
- name: Setup custom URL scheme
run: sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
- name: Test objc quickstart
run: ([ -z $plist_secret ] ||
scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true)
- name: Test swift quickstart
run: ([ -z $plist_secret ] ||
scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true swift)
- name: Remove data before upload
run: scripts/remove_data.sh functions release_testing
- uses: actions/upload-artifact@v4
if: ${{ failure() }}
with:
name: quickstart_artifacts_functions
path: quickstart-ios/
# TODO: The functions quickstart uses Material which isn't supported by Xcode 15
# functions_quickstart:
# # Don't run on private repo unless it is a PR.
# if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch'
# needs: buildup_SpecsTesting_repo
# env:
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
# signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
# bot_token_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
# testing_repo_dir: "/tmp/test/"
# testing_repo: "firebase-ios-sdk"
# LEGACY: true
# runs-on: macos-12
# steps:
# - uses: actions/checkout@v4
# - uses: ruby/setup-ruby@v1
# - name: Get token
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/bot-access.txt.gpg \
# bot-access.txt "$bot_token_secret"
# - name: Setup testing repo and quickstart
# run: |
# botaccess=`cat bot-access.txt`
# BOT_TOKEN="${botaccess}" scripts/setup_quickstart.sh functions nightly_release_testing
# - name: install secret googleservice-info.plist
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-functions.plist.gpg \
# quickstart-ios/functions/GoogleService-Info.plist "$plist_secret"
# - name: Setup custom URL scheme
# run: sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
# - name: Test objc quickstart
# run: ([ -z $plist_secret ] ||
# scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true)
# - name: Test swift quickstart
# run: ([ -z $plist_secret ] ||
# scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true swift)
# - name: Remove data before upload
# run: scripts/remove_data.sh functions release_testing
# - uses: actions/upload-artifact@v4
# if: ${{ failure() }}
# with:
# name: quickstart_artifacts_functions
# path: quickstart-ios/

inappmessaging_quickstart:
# Don't run on private repo unless it is a PR.
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/storage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ jobs:
strategy:
matrix:
include:
- os: macos-13
xcode: Xcode_14.2 # TODO: the legacy ObjC quickstart doesn't build with Xcode 15.
#- os: macos-13
# xcode: Xcode_14.2 # TODO: the legacy ObjC quickstart doesn't build with Xcode 15.
- swift: swift
os: macos-14
xcode: Xcode_15.3
Expand Down
Loading