Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Phone Auth via APNS for Sandbox Tokens and update Sample's Firebase app #13539

Merged
merged 12 commits into from
Aug 26, 2024

Conversation

paulb777
Copy link
Member

Firebase 11.x was not correctly detecting sandbox provisioning profiles

Introduce a new Firebase app for integration testing

Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@paulb777
Copy link
Member Author

Firebase project updates are needed for the API tests

@paulb777
Copy link
Member Author

Updated the Firebase project and remove some deprecated APIs. One issue remains with the Google SignIn tests:

/Users/paulbeusterien/gh3/firebase-ios-sdk/FirebaseAuth/Tests/SampleSwift/SwiftApiTests/GoogleTests.swift:49: error: -[SwiftApiTests.GoogleTests testSignInWithGoogleAsync] : failed: caught error: "Error Domain=FIRAuthErrorDomain Code=17004 "Invalid Idp Response" UserInfo={FIRAuthErrorUserInfoNameKey=ERROR_INVALID_CREDENTIAL, NSLocalizedDescription=Invalid Idp Response}"
Test Case '-[SwiftApiTests.GoogleTests testSignInWithGoogleAsync]' failed (6.910 seconds).

@paulb777 paulb777 added this to the 11.2.0 - M153 milestone Aug 23, 2024
@ncooke3 ncooke3 self-assigned this Aug 26, 2024
@ncooke3 ncooke3 requested a review from andrewheard August 26, 2024 21:02
@ncooke3 ncooke3 merged commit f71480c into main Aug 26, 2024
56 checks passed
@ncooke3 ncooke3 deleted the nc/new-auth-app branch August 26, 2024 22:55
@ncooke3 ncooke3 linked an issue Aug 29, 2024 that may be closed by this pull request
mergify bot referenced this pull request in cgrindel/rules_swift_package_manager Sep 16, 2024
….2.0" (#1228)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[firebase/firebase-ios-sdk](https://github.com/firebase/firebase-ios-sdk)
| minor | `from: "11.1.0"` -> `from: "11.2.0"` |

---

### Release Notes

<details>
<summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary>

###
[`v11.2.0`](https://github.com/firebase/firebase-ios-sdk/releases/tag/11.2.0):
Firebase Apple 11.2.0

[Compare
Source](https://github.com/firebase/firebase-ios-sdk/compare/11.1.0...11.2.0)

The Firebase Apple SDK (11.2.0) is now available. For more details, see
the [Firebase Apple SDK release
notes.](https://firebase.google.com/support/release-notes/ios#11.2.0)

To install this SDK, see [Add Firebase to your
project](https://firebase.google.com/docs/ios/setup).

#### What's Changed

- \[Auth] Phone Auth – Fallback to reCATCHA flow when "invalid app
credential" error is thrown by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/13519](https://github.com/firebase/firebase-ios-sdk/pull/13519)
- \[Auth] Fix Xcode 16 continuation crashes by
[@&#8203;paulb777](https://github.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/13521](https://github.com/firebase/firebase-ios-sdk/pull/13521)
- \[Auth] Fix Phone Auth via APNS for Sandbox Tokens and update Sample's
Firebase app by [@&#8203;paulb777](https://github.com/paulb777)
in
[https://github.com/firebase/firebase-ios-sdk/pull/13539](https://github.com/firebase/firebase-ios-sdk/pull/13539)
- \[Auth] Add background modes capability to plist by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/13548](https://github.com/firebase/firebase-ios-sdk/pull/13548)
- \[Auth] When swizzling is disabled, open URLs via SceneDelegate by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/13557](https://github.com/firebase/firebase-ios-sdk/pull/13557)
- \[Auth] Fix unexpected nil in fetchSignInMethods success case by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/13561](https://github.com/firebase/firebase-ios-sdk/pull/13561)
- \[Auth] Fix user session persistence in multi tenant projects by
[@&#8203;paulb777](https://github.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/13567](https://github.com/firebase/firebase-ios-sdk/pull/13567)
- \[Crashlytics] Fix Firebase/Crashlytics min iOS version by
[@&#8203;paulb777](https://github.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/13580](https://github.com/firebase/firebase-ios-sdk/pull/13580)
- \[Database] Fix temporary disconnect when app goes inactive by
[@&#8203;paulb777](https://github.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/13564](https://github.com/firebase/firebase-ios-sdk/pull/13564)
- \[Firestore] Mark readonly public classes as Sendable by
[@&#8203;paulb777](https://github.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/13453](https://github.com/firebase/firebase-ios-sdk/pull/13453)
- \[Firestore] Support hex strings to prevent broken log lines by
[@&#8203;ls-todd-lunter](https://github.com/ls-todd-lunter) in
[https://github.com/firebase/firebase-ios-sdk/pull/13128](https://github.com/firebase/firebase-ios-sdk/pull/13128)
- \[Functions] `FunctionsContext` Updates by
[@&#8203;yakovmanshin](https://github.com/yakovmanshin) in
[https://github.com/firebase/firebase-ios-sdk/pull/13531](https://github.com/firebase/firebase-ios-sdk/pull/13531)
- \[Functions] Updated Functions Errors by
[@&#8203;yakovmanshin](https://github.com/yakovmanshin) in
[https://github.com/firebase/firebase-ios-sdk/pull/13535](https://github.com/firebase/firebase-ios-sdk/pull/13535)
- \[Testing] Update OCMock dependency to v3.9.4 by
[@&#8203;andrewheard](https://github.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13536](https://github.com/firebase/firebase-ios-sdk/pull/13536)
- \[Vertex AI] Make `uri` optional in `Citation` and add `title` field
by [@&#8203;andrewheard](https://github.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13520](https://github.com/firebase/firebase-ios-sdk/pull/13520)
- \[Vertex AI] Add `Sendable` conformance to types by
[@&#8203;andrewheard](https://github.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13560](https://github.com/firebase/firebase-ios-sdk/pull/13560)
- \[Vertex AI] Make `Logger` properties constants by
[@&#8203;andrewheard](https://github.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13570](https://github.com/firebase/firebase-ios-sdk/pull/13570)
- \[Vertex AI] Make `GenerativeModel` and `Chat` into Swift actors by
[@&#8203;andrewheard](https://github.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13545](https://github.com/firebase/firebase-ios-sdk/pull/13545)
- \[Vertex AI] Make generateContentStream/sendMessageStream throws by
[@&#8203;andrewheard](https://github.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13573](https://github.com/firebase/firebase-ios-sdk/pull/13573)
- \[Vertex AI] Add `SourceImage` enum to `ImageConversionError` by
[@&#8203;andrewheard](https://github.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13575](https://github.com/firebase/firebase-ios-sdk/pull/13575)
- \[Vertex AI] Add `responseSchema` to `GenerationConfig` by
[@&#8203;andrewheard](https://github.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13576](https://github.com/firebase/firebase-ios-sdk/pull/13576)

#### New Contributors

- [@&#8203;ls-todd-lunter](https://github.com/ls-todd-lunter)
made their first contribution in
[https://github.com/firebase/firebase-ios-sdk/pull/13128](https://github.com/firebase/firebase-ios-sdk/pull/13128)

**Full Changelog**:
firebase/firebase-ios-sdk@11.1.0...11.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config
help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: cgrindel-self-hosted-renovate[bot] <139595543+cgrindel-self-hosted-renovate[bot]@users.noreply.github.com>
Co-authored-by: Chuck Grindel <chuck.grindel@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@firebase firebase locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phone Auth not working above iOS 16
4 participants