Fix FirebaseStorageError message recursion bug (#4807)

.changeset/friendly-cooks-tan.md

@@ -0,0 +1,5 @@
+---
+'@firebase/storage': patch
+---
+
+Fix infinite recursion caused by `FirebaseStorageError` message getter.

packages/storage/src/implementation/error.ts

@@ -22,6 +22,7 @@ import { CONFIG_STORAGE_BUCKET_KEY } from './constants';
  * @public
  */
 export class FirebaseStorageError extends FirebaseError {
+  private readonly _baseMessage: string;
   /**
    * Stores custom error data unque to FirebaseStorageError.
    */
@@ -37,6 +38,7 @@ export class FirebaseStorageError extends FirebaseError {
       prependCode(code),
       `Firebase Storage: ${message} (${prependCode(code)})`
     );
+    this._baseMessage = this.message;
     // Without this, `instanceof FirebaseStorageError`, in tests for example,
     // returns false.
     Object.setPrototypeOf(this, FirebaseStorageError.prototype);
@@ -49,17 +51,6 @@ export class FirebaseStorageError extends FirebaseError {
     return prependCode(code) === this.code;
   }
 
-  /**
-   * Error message including serverResponse if available.
-   */
-  get message(): string {
-    if (this.customData.serverResponse) {
-      return `${this.message}\n${this.customData.serverResponse}`;
-    } else {
-      return this.message;
-    }
-  }
-
   /**
    * Optional response message that was added by the server.
    */
@@ -69,6 +60,11 @@ export class FirebaseStorageError extends FirebaseError {
 
   set serverResponse(serverResponse: string | null) {
     this.customData.serverResponse = serverResponse;
+    if (this.customData.serverResponse) {
+      this.message = `${this._baseMessage}\n${this.customData.serverResponse}`;
+    } else {
+      this.message = this._baseMessage;
+    }
   }
 }