auto-init auth-internal after initializing auth (#5071)

* auto-init auth-internal after initializing auth * Create sixty-masks-wash.md
firebase · Jun 28, 2021 · 56a6a9d · 56a6a9d
1 parent 1bbdbfe
commit 56a6a9d
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 3 deletions.
diff --git a/.changeset/sixty-masks-wash.md b/.changeset/sixty-masks-wash.md
@@ -0,0 +1,6 @@
+---
+"@firebase/auth": patch
+"@firebase/component": patch
+---
+
+Auto initialize `auth-internal` after `auth` has been initialized.
diff --git a/packages/auth/src/exports_auth.js b/packages/auth/src/exports_auth.js
@@ -761,7 +761,16 @@ fireauth.exportlib.exportFunction(
       'multipleInstances': false,
       'serviceProps': namespace,
       'instantiationMode': 'LAZY',
-      'type':  'PUBLIC'
+      'type':  'PUBLIC',
+      /**
+       * Initialize auth-internal after auth is initialized to make auth available to other firebase products.
+       */
+      'onInstanceCreated': function (container, _instanceIdentifier, _instance) {
+          const authInternalProvider = container['getProvider'](
+            'auth-internal'
+          );
+          authInternalProvider['initialize']();
+        }
     };
 
     // Provides Auth internal APIs.

diff --git a/packages/component/src/provider.ts b/packages/component/src/provider.ts
@@ -251,8 +251,6 @@ export class Provider<T extends Name> {
       }
     }
 
-    this.invokeOnInitCallbacks(instance, normalizedIdentifier);
-
     return instance;
   }
 
@@ -318,6 +316,13 @@ export class Provider<T extends Name> {
       });
       this.instances.set(instanceIdentifier, instance);
 
+      /**
+       * Invoke onInit listeners.
+       * Note this.component.onInstanceCreated is different, which is used by the component creator,
+       * while onInit listeners are registered by consumers of the provider.
+       */
+      this.invokeOnInitCallbacks(instance, instanceIdentifier);
+
       /**
        * Order is important
        * onInstanceCreated() should be called after this.instances.set(instanceIdentifier, instance); which