Specify customData structure for FirebaseStorageError type

firebase · Oct 16, 2020 · 8ec97ca · 8ec97ca
1 parent a934feb
commit 8ec97ca
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/packages/firebase/index.d.ts b/packages/firebase/index.d.ts
@@ -7620,7 +7620,9 @@ declare namespace firebase.storage {
   /**
    * An error returned by the Firebase Storage SDK.
    */
-  interface FirebaseStorageError extends FirebaseError {}
+  interface FirebaseStorageError extends FirebaseError {
+    customData: { serverResponse: string | null };
+  }
 
   interface StorageObserver<T> {
     next?: NextFn<T> | null;

diff --git a/packages/storage-types/index.d.ts b/packages/storage-types/index.d.ts
@@ -85,7 +85,9 @@ export interface UploadMetadata extends SettableMetadata {
   md5Hash?: string | null;
 }
 
-export interface FirebaseStorageError extends FirebaseError {}
+interface FirebaseStorageError extends FirebaseError {
+  customData: { serverResponse: string | null };
+}
 
 export interface StorageObserver<T> {
   next?: NextFn<T> | null;

diff --git a/packages/storage/src/implementation/error.ts b/packages/storage/src/implementation/error.ts
@@ -18,14 +18,13 @@ import { FirebaseError } from '@firebase/util';
 import { CONFIG_STORAGE_BUCKET_KEY } from './constants';
 
 export class FirebaseStorageError extends FirebaseError {
-  customData: { serverResponse: string | null };
+  customData: { serverResponse: string | null } = { serverResponse: null };
 
   constructor(code: Code, message: string) {
     super(prependCode(code), 'Firebase Storage: ' + message);
     // Without this, `instanceof FirebaseStorageError`, in tests for example,
     // returns false.
     Object.setPrototypeOf(this, FirebaseStorageError.prototype);
-    this.customData = { serverResponse: null };
   }
 
   codeEquals(code: Code): boolean {