Address PR feedback

firebase · Nov 10, 2022 · bb3c4ed · bb3c4ed
1 parent a20a324
commit bb3c4ed
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.changeset/empty-doors-brush.md b/.changeset/empty-doors-brush.md
@@ -0,0 +1,6 @@
+---
+'@firebase/database': patch
+'@firebase/database-compat': patch
+---
+
+Use new wire protocol parameters for startAfter, endBefore.
diff --git a/scripts/emulator-testing/emulators/database-emulator.ts b/scripts/emulator-testing/emulators/database-emulator.ts
@@ -21,16 +21,18 @@ import { Emulator } from './emulator';
 
 import rulesJSON from '../../../config/database.rules.json';
 
+const DATABASE_EMULATOR_VERSION = '4.11.0';
+
 export class DatabaseEmulator extends Emulator {
   namespace: string;
 
   constructor(port = 8088, namespace = 'test-emulator') {
     super(
-      'firebase-database-emulator-v4.11.0.jar',
+      `firebase-database-emulator-v${DATABASE_EMULATOR_VERSION}.jar`,
       // Use locked version of emulator for test to be deterministic.
       // The latest version can be found from database emulator doc:
       // https://firebase.google.com/docs/database/security/test-rules-emulator
-      'https://storage.googleapis.com/firebase-preview-drop/emulator/firebase-database-emulator-v4.11.0.jar',
+      `https://storage.googleapis.com/firebase-preview-drop/emulator/firebase-database-emulator-v${DATABASE_EMULATOR_VERSION}.jar`,
       port
     );
     this.namespace = namespace;