Add timeout constant and bring back minimum timeout value

firebase · Dec 3, 2024 · f12e7c8 · f12e7c8
1 parent e9ae353
commit f12e7c8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/vertexai/src/constants.ts b/packages/vertexai/src/constants.ts
@@ -28,3 +28,5 @@ export const DEFAULT_API_VERSION = 'v1beta';
 export const PACKAGE_VERSION = version;
 
 export const LANGUAGE_TAG = 'gl-js';
+
+export const DEFAULT_FETCH_TIMEOUT_MS = 180 * 1000;
diff --git a/packages/vertexai/src/requests/request.ts b/packages/vertexai/src/requests/request.ts
@@ -21,6 +21,7 @@ import { ApiSettings } from '../types/internal';
 import {
   DEFAULT_API_VERSION,
   DEFAULT_BASE_URL,
+  DEFAULT_FETCH_TIMEOUT_MS,
   LANGUAGE_TAG,
   PACKAGE_VERSION
 } from '../constants';
@@ -145,9 +146,9 @@ export async function makeRequest(
     );
     // Timeout is 180s by default
     const timeoutMillis =
-      requestOptions?.timeout !== undefined
+      requestOptions?.timeout !== undefined && requestOptions.timeout >= 0
         ? requestOptions.timeout
-        : 180 * 1000;
+        : DEFAULT_FETCH_TIMEOUT_MS;
     const abortController = new AbortController();
     fetchTimeoutId = setTimeout(() => abortController.abort(), timeoutMillis);
     request.fetchOptions.signal = abortController.signal;
Original file line number	Diff line number	Diff line change
Expand Up		@@ -28,3 +28,5 @@ export const DEFAULT_API_VERSION = 'v1beta';
		export const PACKAGE_VERSION = version;

		export const LANGUAGE_TAG = 'gl-js';

		export const DEFAULT_FETCH_TIMEOUT_MS = 180 * 1000;