Use friendlier language in rename-internals (#5306)

firebase · Aug 16, 2021 · fb27f50 · fb27f50
1 parent 89f8665
commit fb27f50
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/.changeset/gold-ghosts-argue.md b/.changeset/gold-ghosts-argue.md
@@ -0,0 +1,2 @@
+---
+---
diff --git a/packages/firestore/scripts/rename-internals.js b/packages/firestore/scripts/rename-internals.js
@@ -14,4 +14,4 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
- */exports.__esModule=true;exports.renameInternals=void 0;var ts=require("typescript");var blacklist=["undefined"];var RenameInternals=function(){function RenameInternals(publicApi,prefix){this.publicApi=publicApi;this.prefix=prefix}RenameInternals.prototype.visitNodeAndChildren=function(node,context){var _this=this;return ts.visitEachChild(this.visitNode(node),(function(childNode){return _this.visitNodeAndChildren(childNode,context)}),context)};RenameInternals.prototype.visitNode=function(node){if(ts.isIdentifier(node)){var name_1=node.escapedText.toString();if(!this.publicApi.has(name_1)&&blacklist.indexOf(node.escapedText.toString())===-1){var newIdentifier=ts.createIdentifier(this.prefix+name_1);ts.setSourceMapRange(newIdentifier,ts.getSourceMapRange(node));return newIdentifier}}return node};return RenameInternals}();var DEFAULT_PREFIX="_";function renameInternals(program,config){var _a;var prefix=(_a=config.prefix)!==null&&_a!==void 0?_a:DEFAULT_PREFIX;var renamer=new RenameInternals(config.publicIdentifiers,prefix);return function(context){return function(file){return renamer.visitNodeAndChildren(file,context)}}}exports.renameInternals=renameInternals;
+ */exports.__esModule=true;exports.renameInternals=void 0;var ts=require("typescript");var ignoredIdentifiers=["undefined"];var RenameInternals=function(){function RenameInternals(publicApi,prefix){this.publicApi=publicApi;this.prefix=prefix}RenameInternals.prototype.visitNodeAndChildren=function(node,context){var _this=this;return ts.visitEachChild(this.visitNode(node),(function(childNode){return _this.visitNodeAndChildren(childNode,context)}),context)};RenameInternals.prototype.visitNode=function(node){if(ts.isIdentifier(node)){var name_1=node.escapedText.toString();if(!this.publicApi.has(name_1)&&ignoredIdentifiers.indexOf(node.escapedText.toString())===-1){var newIdentifier=ts.createIdentifier(this.prefix+name_1);ts.setSourceMapRange(newIdentifier,ts.getSourceMapRange(node));return newIdentifier}}return node};return RenameInternals}();var DEFAULT_PREFIX="_";function renameInternals(program,config){var _a;var prefix=(_a=config.prefix)!==null&&_a!==void 0?_a:DEFAULT_PREFIX;var renamer=new RenameInternals(config.publicIdentifiers,prefix);return function(context){return function(file){return renamer.visitNodeAndChildren(file,context)}}}exports.renameInternals=renameInternals;
diff --git a/packages/firestore/scripts/rename-internals.ts b/packages/firestore/scripts/rename-internals.ts
@@ -18,7 +18,7 @@
 import * as ts from 'typescript';
 
 // `undefined` is treated as an identifier by TSC, but not part of any externs.
-const blacklist = ['undefined'];
+const ignoredIdentifiers = ['undefined'];
 
 /**
  * Processes TypeScript source files and renames all identifiers that do not
@@ -46,7 +46,7 @@ class RenameInternals {
       const name = node.escapedText.toString();
       if (
         !this.publicApi.has(name) &&
-        blacklist.indexOf(node.escapedText.toString()) === -1
+        ignoredIdentifiers.indexOf(node.escapedText.toString()) === -1
       ) {
         const newIdentifier = ts.createIdentifier(this.prefix + name);
         ts.setSourceMapRange(newIdentifier, ts.getSourceMapRange(node));