update npm-run-all to avoid potential exploit #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiyang1
requested review from
bojeil-google,
davideast,
depoll,
dwoffinden,
gsoltis,
hiranya911,
mikelehen,
mmermerkaya and
pinarx
as code owners
Feiyang1
requested review from
rsgowman,
schmidt-sebastian,
var-const,
wilhuff and
zxu123
as code owners
mikelehen
suggested changes
Nov 30, 2018
packages/testing/src/api/index.ts
Outdated
| // efficiency is less important than responsiveness. | ||
| 'grpc.initial_reconnect_backoff_ms': 100, | ||
| 'grpc.max_reconnect_backoff_ms': 100 | ||
| } |
There was a problem hiding this comment.
Where is this change coming from?
There was a problem hiding this comment.
I think I know what's going on. I rebased the master yesterday after the release and the PRs are submitted before the rebase. Rebasing the PR should solve the problem.
There was a problem hiding this comment.
It is removed from the PR.
mikelehen
approved these changes
Nov 30, 2018
mmermerkaya
approved these changes
Nov 30, 2018
bojeil-google
approved these changes
Dec 4, 2018
|
@davideast ping |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A npm package we transitively depend on was hacked and was injected with malicious code. Our repo is not affected thanks to the fixed version and the lock file. As a precaution, I'm upgrading the library which removed the dependency on the hacked library.
More detail: #1400