-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Error to FirestoreError #3418
Conversation
🦋 Changeset is good to goLatest commit: 7594809 We got this. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…nd firestore-types/index.d.ts.
Binary Size ReportAffected SDKsNo changes between base commit (f47f990) and head commit (5abf4fc). Test Logs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the callsites that you changed and verified that we only call them with a FirestoreError Everything else would have been a huge surprise. Please obtain API council approval before merging and add a Changeset.
Size Analysis ReportAffected ProductsNo changes between base commit (f47f990) and head commit (5abf4fc). Test Logs
|
Changeset File Check
|
I'm going to merge despite the "Test All Packages" check failing. Its failure is due to a timeout and is not critical to this feature. |
Change the signature of
onSnapshot()
andonSnapshotsInSync()
methods to reportFirestoreError
instead of a genericError
. This allows users to extract the error code from the error without having to do a questionable cast.This will address #1515 for Firestore. A separate PR will be needed for Storage.