Update Auth Firefox cross browser action to only run on changed auth files #6546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
hsubox76
reviewed
Aug 19, 2022
hsubox76
reviewed
Aug 19, 2022
scripts/run_tests_in_ci.js
Outdated
| @@ -21,6 +21,9 @@ const { spawn } = require('child-process-promise'); | |||
| const { writeFileSync } = require('fs'); | |||
|
|
|||
| const LOGDIR = process.env.CI ? process.env.HOME : '/tmp'; | |||
| // Maps the packages that have standalone cross browser testing to the necessary test script. | |||
There was a problem hiding this comment.
It happens to be that we need these for Firestore and Auth, and also that they happen to not be part of test:changed core, but that's more of a coincidence. The distinguishing feature is that these are packages where we should not run test:all (or whatever argument is passed to the script using the -s flag in the package's version of test:ci) for cross-browser tests. Storage basically has the same problem but we solved it by editing karma.conf.js instead. We may actually want to change storage (in the future, in another PR) to use this same method, for consistency.
hsubox76
approved these changes
Aug 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Auth Firefox cross browser action to only run on changed auth files. In the previous iteration, we ran the unit tests irrespective of changed auth files which is incongruent with the purpose of the github action