Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potentially false warning message. #7339

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Fix potentially false warning message. #7339

merged 2 commits into from
Jun 6, 2023

Conversation

ehsannas
Copy link
Contributor

Fixes #7331.

@ehsannas ehsannas requested a review from MarkDuckworth May 30, 2023 22:42
@ehsannas ehsannas requested review from a team as code owners May 30, 2023 22:42
@changeset-bot
Copy link

changeset-bot bot commented May 30, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: dc3436f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ehsannas ehsannas assigned MarkDuckworth and ehsannas and unassigned ehsannas May 30, 2023
@ehsannas ehsannas requested a review from a team as a code owner May 30, 2023 22:42
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 30, 2023 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (ce61896)Merge (5fed36a)Diff
    browser286 kB286 kB+18 B (+0.0%)
    esm5355 kB355 kB+18 B (+0.0%)
    main568 kB568 kB+60 B (+0.0%)
    module286 kB286 kB+18 B (+0.0%)
    react-native286 kB286 kB+18 B (+0.0%)

  • @firebase/firestore-lite

    TypeBase (ce61896)Merge (5fed36a)Diff
    browser88.3 kB88.3 kB+18 B (+0.0%)
    esm5106 kB106 kB+18 B (+0.0%)
    main151 kB151 kB+60 B (+0.0%)
    module88.3 kB88.3 kB+18 B (+0.0%)
    react-native88.5 kB88.5 kB+18 B (+0.0%)

  • bundle

    12 size changes

    TypeBase (ce61896)Merge (5fed36a)Diff
    firestore (Persistence)300 kB300 kB+18 B (+0.0%)
    firestore (Query Cursors)238 kB238 kB+18 B (+0.0%)
    firestore (Query)235 kB235 kB+18 B (+0.0%)
    firestore (Read data once)223 kB223 kB+18 B (+0.0%)
    firestore (Realtime updates)225 kB225 kB+18 B (+0.0%)
    firestore (Transaction)202 kB202 kB+18 B (+0.0%)
    firestore (Write data)202 kB202 kB+18 B (+0.0%)
    firestore-lite (Query Cursors)82.6 kB82.6 kB+18 B (+0.0%)
    firestore-lite (Query)78.7 kB78.7 kB+18 B (+0.0%)
    firestore-lite (Read data once)60.9 kB60.9 kB+18 B (+0.0%)
    firestore-lite (Transaction)85.6 kB85.6 kB+18 B (+0.0%)
    firestore-lite (Write data)70.4 kB70.4 kB+18 B (+0.0%)

  • firebase

    TypeBase (ce61896)Merge (5fed36a)Diff
    firebase-compat.js773 kB773 kB+18 B (+0.0%)
    firebase-firestore-compat.js339 kB339 kB+18 B (+0.0%)
    firebase-firestore-lite.js95.1 kB95.1 kB+18 B (+0.0%)
    firebase-firestore.js346 kB346 kB+18 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kJNNzNkeEw.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 30, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • connectFirestoreEmulator

      Size

      TypeBase (ce61896)Merge (5fed36a)Diff
      size19.4 kB19.4 kB+18 B (+0.1%)
      size-with-ext-deps89.6 kB89.6 kB+18 B (+0.0%)

    • getFirestore

      Size

      TypeBase (ce61896)Merge (5fed36a)Diff
      size19.7 kB19.7 kB+18 B (+0.1%)
      size-with-ext-deps97.5 kB97.5 kB+18 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KkRiUHmPKR.html

@egilmorez egilmorez requested a review from markarndt June 1, 2023 16:37
MarkDuckworth
MarkDuckworth approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MarkDuckworth
MarkDuckworth approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehsannas ehsannas merged commit fe7da7e into master Jun 6, 2023
@ehsannas ehsannas deleted the ehsann/fix-warning branch June 6, 2023 16:51
@google-oss-bot google-oss-bot mentioned this pull request Jun 6, 2023
Merged
dwyfrequency pushed a commit that referenced this pull request Jun 16, 2023
@ehsannas @dwyfrequency
Fix potentially false warning message. (#7339)
51e1b77 
* Fix potentially false warning message.

Fixes #7331.

* Create giant-bees-clean.md
@firebase firebase locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

@markarndt markarndt Awaiting requested review from markarndt

Assignees

@MarkDuckworth MarkDuckworth

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ehsannas @google-oss-bot @MarkDuckworth