Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename fakePassword variable in tests ax #7362

Merged
merged 8 commits into from
Jun 14, 2023
Merged

rename fakePassword variable in tests ax #7362

merged 8 commits into from
Jun 14, 2023

Conversation

AngelAngelXie
Copy link
Contributor

Fixing variable name in test from fakePassword to password

@changeset-bot
Copy link

changeset-bot bot commented Jun 12, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: c114277

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

prameshj
prameshj approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the pull request title to say "rename fakePassword variable in tests". Thanks!

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (e522056) and merge commit (c596f35).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/FFgVEIxMjK.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (e522056) and merge commit (c596f35).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HgCTomlXfT.html

@AngelAngelXie AngelAngelXie merged commit 8e9aac2 into master Jun 14, 2023
@AngelAngelXie AngelAngelXie deleted the Fixing-interdependency-in-mfa-totp-Integration-tests-ax branch June 14, 2023 17:31
dwyfrequency pushed a commit that referenced this pull request Jun 16, 2023
@AngelAngelXie @dwyfrequency
Fixing interdependency in mfa totp integration tests ax (#7362)
e51ef96 
* reorganized mfa totp integration tests

* formatted the code

* added await for enroll function calls

* created fakePassword to store password

* fixed typo in mfaUser

* moved fakePassword into integration helpers file

* changed fakePassword var name to password
@firebase firebase locked and limited conversation to collaborators Jul 15, 2023
@AngelAngelXie AngelAngelXie changed the title Fixing interdependency in mfa totp integration tests ax rename fakePassword variable in tests ax Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@renkelvin renkelvin renkelvin approved these changes

@prameshj prameshj prameshj approved these changes

@lisajian lisajian Awaiting requested review from lisajian

@sam-gc sam-gc Awaiting requested review from sam-gc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AngelAngelXie @google-oss-bot @renkelvin @prameshj