Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for existence filter with updated/added documents #7457

Merged
merged 11 commits into from
Sep 5, 2023
Merged

Add test cases for existence filter with updated/added documents #7457

merged 11 commits into from
Sep 5, 2023

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Jul 13, 2023 •
edited
Loading

Adding more spec tests and integration test to cover different snerios in using bloom filter.
Snerios include updating, removing, deleting and adding documents while users gets offline.

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: a08188e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 13, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (2d0a9f5) and merge commit (fb87e48).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Q5iqfFITha.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 13, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (2d0a9f5) and merge commit (fb87e48).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GrYg0HoVpj.html

@milaGGL milaGGL self-assigned this Aug 16, 2023
@milaGGL milaGGL changed the title Fix the bloom filter bug in handling updated documents Add test cases for existence filter with updated/added documents Aug 16, 2023
@milaGGL milaGGL requested a review from dconeybe August 16, 2023 20:20
@milaGGL milaGGL marked this pull request as ready for review August 16, 2023 20:26
@milaGGL milaGGL requested review from a team as code owners August 16, 2023 20:26
@DellaBitta
Copy link
Contributor

Please add a PR description for context for our current and future review. Thanks!

dconeybe
dconeybe requested changes Aug 17, 2023
View reviewed changes
packages/firestore/test/unit/specs/limbo_spec.test.ts Outdated Show resolved Hide resolved
packages/firestore/test/integration/api/query.test.ts Outdated Show resolved Hide resolved
packages/firestore/test/integration/api/query.test.ts Outdated Show resolved Hide resolved
packages/firestore/test/integration/api/query.test.ts Outdated Show resolved Hide resolved
packages/firestore/test/integration/api/query.test.ts Outdated Show resolved Hide resolved
packages/firestore/test/integration/api/query.test.ts Outdated Show resolved Hide resolved
packages/firestore/test/integration/api/query.test.ts Outdated Show resolved Hide resolved
packages/firestore/test/unit/specs/existence_filter_spec.test.ts Outdated Show resolved Hide resolved
packages/firestore/test/unit/specs/existence_filter_spec.test.ts Outdated Show resolved Hide resolved
packages/firestore/test/unit/specs/existence_filter_spec.test.ts Outdated Show resolved Hide resolved
@milaGGL milaGGL requested a review from dconeybe August 28, 2023 18:40
@milaGGL milaGGL requested a review from dconeybe August 31, 2023 17:34
@milaGGL milaGGL merged commit 74fc4cf into master Sep 5, 2023
40 of 41 checks passed
@milaGGL milaGGL deleted the mila/fix-bloom-filter-doc-update-bug branch September 5, 2023 14:13
@milaGGL milaGGL mentioned this pull request Sep 6, 2023
Merged
@milaGGL milaGGL mentioned this pull request Sep 8, 2023
Merged
milaGGL added a commit to firebase/firebase-android-sdk that referenced this pull request Sep 11, 2023
@milaGGL
Add test cases for existence filter with updated, removed, added docu…
dfa22c7 
…ments (#5308)

ported from: firebase/firebase-js-sdk#7457
@firebase firebase locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@milaGGL milaGGL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@milaGGL @google-oss-bot @DellaBitta @dconeybe