Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency express to v4.19.2 [SECURITY] - autoclosed #8108

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 28, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
express (source) 4.18.2 -> 4.19.2 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-29041

Impact

Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.

When a user of Express performs a redirect using a user-provided URL Express performs an encode using encodeurl on the contents before passing it to the location header. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.

The main method impacted is res.location() but this is also called from within res.redirect().

Patches

expressjs/express@0867302
expressjs/express@0b74695

An initial fix went out with express@4.19.0, we then patched a feature regression in 4.19.1 and added improved handling for the bypass in 4.19.2.

Workarounds

The fix for this involves pre-parsing the url string with either require('node:url').parse or new URL. These are steps you can take on your own before passing the user input string to res.location or res.redirect.

References

https://github.com/expressjs/express/pull/5539
https://github.com/koajs/koa/issues/1800
https://expressjs.com/en/4x/api.html#res.location


Release Notes

expressjs/express (express)

v4.19.2

Compare Source

==========

  • Improved fix for open redirect allow list bypass

v4.19.1

Compare Source

==========

  • Allow passing non-strings to res.location with new encoding handling checks

v4.19.0

Compare Source

v4.18.3

Compare Source

==========

  • Fix routing requests without method
  • deps: body-parser@1.20.2
    • Fix strict json error message on Node.js 19+
    • deps: content-type@~1.0.5
    • deps: raw-body@2.5.2

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested review from zwu52 and a team as code owners March 28, 2024 17:33
Copy link

changeset-bot bot commented Mar 28, 2024

⚠️ No Changeset found

Latest commit: 51c1357

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

DellaBitta added a commit that referenced this pull request Apr 3, 2024
### Discussion

Updating a series of Renovate-found outdated dependencies.

Including:

 - PR: #7770
 - PR: #7571
 - PR: #7450
 - PR: #4827
 - PR #8108

Additional minor dependency updates based on the renovate PR #5566:

 - `@babel/core`: `7.22.11 -> 7.24.3`
 - `@babel/register`: `7.22.5 -> 7.23.7`
 - `@rushstack/ts-command-line`: `4.15.2 -> 4.19.1`
 - `@types/chai`: `4.3.5 -> 4.3.14`
 - `@types/chai-as-promised`: `7.1.5 -> 7.1.8`
 - `@types/child-process-promise`: `2.2.2 -> 2.2.6`
 - `@types/express`: `4.17.17 -> 4.17.21`
 - `@types/inquirer`: `8.2.6 -> 8.2.10`
 - `@types/js-yaml`: `4.0.5 -> 4.0.9`
 - `@types/json-stable-stringify`: `1.0.34 -> 1.0.36`
 - `@types/listr`: `0.14.4 -> 0.14.9`
 - `@types/mz`: `2.7.4 -> 2.7.8`
 - `@types/request`: `2.48.8 -> 2.48.12`
 - `@types/sinon-chai`: `3.2.9 -> 3.2.12`
 - `@types/resolve`: `1.20.2 -> 1.20.6`
 - `@types/tmp`: `0.2.3 -> 0.2.6`
 - `@types/trusted-types`: `2.0.3 -> 2.0.7`
 - `@types/webpack `: `5.28.0 -> 5.28.5`
 - `@types/yargs`: `17.0.24 -> 17.0.32`
 - `chai`: `4.3.7 -> 4.4.1`
 - `firebase-admin`: `11.10.1 -> 11.11.1`
 - `json-stable-stringify`: `1.0.2 -> 1.1.1`
- `rollup-plugin-copy`:  `3.4.0 -> 3.5.0`
- `rollup-plugin-dts`: `5.3.0 -> 5.3.1`
 - `rollup-plugin-license`: `3.0.1 -> 3.3.1`
 - `karma-webpack`: `5.0.0 -> 5.0.1`
 - `karma-firefox-launcher`: `2.1.2 -> 2.1.3`
 - `karma-spec-reporter`: `0.0.34 -> 0.0.36`
- `patch-package`: `7.0.0 -> 7.0.2`
- `protobufjs`: `7.2.4 -> 7.2.6`
- `simple-git`: `3.19.1 -> 3.24.0`
@renovate renovate bot changed the title Update dependency express to v4.19.2 [SECURITY] Update dependency express to v4.19.2 [SECURITY] - autoclosed Apr 3, 2024
@renovate renovate bot closed this Apr 3, 2024
@renovate renovate bot deleted the renovate/npm-express-vulnerability branch April 3, 2024 19:45
@firebase firebase locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants