-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from the Node to the Web ReadableStream #8410
Conversation
🦋 Changeset detectedLatest commit: 85a432a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changeset File Check ✅
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (631,171 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, just have some questions on the new TransformStream syntax maybe just because I am unfamiliar with it. Maybe we can walk through quickly offline.
62ba71b
to
01854cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
In the past, we used
node-fetch
, which used theNodeJS.ReadableStream
interface for streaming requests. When we moved toundici
(#7705), we began using the WebReadableStream
interface under the hood, but did not update our usage of the interface, so users began seeing errors when usinggetStream
(#8303).To fix this issue, we need to migrate from the Node to the Web
ReadableStream
interface.This will help us in the future when we migrate to native Node
fetch
, since that also uses the WebReadableStream
interface.Fixes #8303