Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a custom path in Firebase functions custom domain #8441

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

segevfiner
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Fixes #8440

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@segevfiner segevfiner requested a review from a team as a code owner August 19, 2024 16:28
Copy link

changeset-bot bot commented Aug 19, 2024

🦋 Changeset detected

Latest commit: 1eeb535

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/functions Patch
firebase Patch
@firebase/functions-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@segevfiner segevfiner requested review from a team as code owners August 19, 2024 16:29
Copy link
Contributor

@taeold taeold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Copy link
Contributor

@dlarocque dlarocque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

packages/functions/src/service.ts Outdated Show resolved Hide resolved
Co-authored-by: Daniel La Rocque <dlarocque.contact@gmail.com>
@segevfiner
Copy link
Contributor Author

Hrmmm. @dlarocque CLA error on your email for some reason...?

@dlarocque dlarocque merged commit 2ee2a90 into firebase:main Aug 19, 2024
22 of 26 checks passed
@segevfiner segevfiner deleted the firebase-functions-custom-path branch August 19, 2024 22:13
@google-oss-bot google-oss-bot mentioned this pull request Aug 27, 2024
@firebase firebase locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firebase/functions does not respect a custom path the in the customDomain parameter
3 participants