Fix analytics test warnings #8556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Report 1Affected ProductsNo changes between base commit (d6fa588) and merge commit (2a7f1c0).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (d6fa588) and merge commit (2a7f1c0).Test Logs |
DellaBitta
approved these changes
Oct 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analytics test logs had a lot of spam with warnings that the app is already deleted. This actually didn't come from a call to deleteApp() but a reference to
app.name(which is actually a getter function) in a heartbeatService method. This is because some of the analytics tests use a full FirebaseApp initialized with initializeApp instead of a stub, which causes heartbeatService to also be initialized and start running its lifecycle methods.The solution is to replace the heartbeatService component in the app used for testing, a fix which was already done in AppCheck, probably for the same problem https://github.com/firebase/firebase-js-sdk/blob/main/packages/app-check/test/util.ts#L70 Analytics tests don't need to test the heartbeatService so it makes sense to stub it out.