Fixes bugs when saving system params to manifest (#5532)

* Fixes bugs when saving system params to manifest

* Linting

* ReplaceAll is not defined in node14 :(

* Fixing tests

* Removes .only

src/extensions/manifest.ts

@@ -201,7 +201,7 @@ async function writeEnvFiles(
 ): Promise<void> {
   for (const spec of specs) {
     const content = Object.entries(spec.params)
-      .filter((r) => r[1].baseValue !== "") // Don't write empty values
+      .filter((r) => r[1].baseValue !== "" && r[1].baseValue !== undefined) // Don't write empty values
       .sort((a, b) => {
         return a[0].localeCompare(b[0]);
       })

src/prompt.ts

@@ -91,7 +91,9 @@ export async function promptOnce<A extends inquirer.Answers>(
  * @return The value as returned by `inquirer` for that quesiton.
  */
 export async function promptOnce<A>(question: Question, options: Options = {}): Promise<A> {
-  question.name = question.name || "question";
+  // Need to replace any .'s in the question name - otherwise, Inquirer puts the answer
+  // in a nested object like so: `"a.b.c" => {a: {b: {c: "my-answer"}}}`
+  question.name = question.name?.replace(/\./g, "/") || "question";
   await prompt(options, [question]);
   return options[question.name];
 }

src/test/prompt.spec.ts

@@ -9,6 +9,7 @@ describe("prompt", () => {
   let inquirerStub: sinon.SinonStub;
   const PROMPT_RESPONSES = {
     lint: true,
+    "lint/dint/mint": true,
     project: "the-best-project-ever",
   };
 
@@ -73,5 +74,12 @@ describe("prompt", () => {
       expect(r).to.equal(true);
       expect(inquirerStub).calledOnce;
     });
+
+    it("should handle names with .'s", async () => {
+      const r = await prompt.promptOnce({ name: "lint.dint.mint" });
+
+      expect(r).to.equal(true);
+      expect(inquirerStub).calledOnce;
+    });
   });
 });