Skip to content

Commit

Permalink
Fix output buffer pipe issue (#5310)
Browse files Browse the repository at this point in the history
* Fixed issue where piped results were truncated

* Fixed pipe limit issue

* Update CHANGELOG.md

---------

Co-authored-by: joehan <joehanley@google.com>
  • Loading branch information
maneesht and joehan authored Sep 11, 2023
1 parent 48ee7a1 commit 8cf0fd2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- Released Firestore emulator v1.18.2.
- Removed nano precision in timestamp used in Firestore emulator (#5893)
- Fixed a bug where query behaves differently from production.
- Fixed an issue where very long command outputs would be cut off. (#3286)
5 changes: 2 additions & 3 deletions src/command.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export class Command {
}

/**
* Registers the command with the client. This is used to inisially set up
* Registers the command with the client. This is used to initially set up
* all the commands and wraps their functionality with analytics and error
* handling.
* @param client the client object (from src/index.js).
Expand Down Expand Up @@ -190,7 +190,7 @@ export class Command {
runner(...args)
.then(async (result) => {
if (getInheritedOption(options, "json")) {
console.log(
process.stdout.write(
JSON.stringify(
{
status: "success",
Expand Down Expand Up @@ -222,7 +222,6 @@ export class Command {
])
);
}
process.exit();
})
.catch(async (err) => {
if (getInheritedOption(options, "json")) {
Expand Down

0 comments on commit 8cf0fd2

Please sign in to comment.