Skip to content

Commit

Permalink
Add Service Usage Consumer role to GitHub Actions service account (#6895
Browse files Browse the repository at this point in the history
)

* Add Service Usage Consumer role to GitHub Actions service account

* Added a changelog entry
  • Loading branch information
aalej authored Mar 26, 2024
1 parent 4c1bd42 commit ccab9b7
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
- Fixes issue where GitHub actions service account cannot add preview URLs to Auth authorized domains (#6895)
- Release Firestore Emulator 1.19.4. This version fixes a minor bug with reserve ids and adds a `reset` endpoint for Datastore Mode.
1 change: 1 addition & 0 deletions src/gcp/resourceManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export const firebaseRoles = {
functionsDeveloper: "roles/cloudfunctions.developer",
hostingAdmin: "roles/firebasehosting.admin",
runViewer: "roles/run.viewer",
serviceUsageConsumer: "roles/serviceusage.serviceUsageConsumer",
};

/**
Expand Down
4 changes: 4 additions & 0 deletions src/init/features/hosting/github.ts
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,10 @@ async function createServiceAccountAndKey(
// https://github.com/firebase/firebase-tools/issues/2732
firebaseRoles.authAdmin,

// Required to add preview URLs to Auth authorized domains
// https://github.com/firebase/firebase-tools/issues/6828
firebaseRoles.serviceUsageConsumer,

// Required for CLI deploys
firebaseRoles.apiKeysViewer,

Expand Down

0 comments on commit ccab9b7

Please sign in to comment.