Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor api.ts file constants to getters #6913

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Refactor api.ts file constants to getters #6913

merged 4 commits into from
Mar 26, 2024

Conversation

hlshen
Copy link
Contributor

@hlshen hlshen commented Mar 25, 2024

Description

Scenarios Tested

Sample Commands

@hlshen hlshen requested a review from joehan March 25, 2024 23:16
@hlshen hlshen enabled auto-merge (squash) March 25, 2024 23:31
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 78.91566% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 54.44%. Comparing base (c6d1615) to head (6dc1c67).

Files Patch % Lines
src/api.ts 91.74% 8 Missing and 1 partial ⚠️
src/gcp/storage.ts 0.00% 7 Missing ⚠️
src/auth.ts 0.00% 5 Missing ⚠️
src/extensions/extensionsHelper.ts 25.00% 3 Missing ⚠️
src/deploy/functions/containerCleaner.ts 33.33% 2 Missing ⚠️
src/deploy/functions/build.ts 0.00% 1 Missing ⚠️
src/deploy/functions/prepare.ts 0.00% 1 Missing ⚠️
src/deploy/index.ts 0.00% 1 Missing ⚠️
src/extensions/resolveSource.ts 0.00% 1 Missing ⚠️
src/extensions/secretsUtils.ts 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6913      +/-   ##
==========================================
+ Coverage   54.37%   54.44%   +0.07%     
==========================================
  Files         353      353              
  Lines       24602    24652      +50     
  Branches     5094     5094              
==========================================
+ Hits        13378    13423      +45     
- Misses      10006    10012       +6     
+ Partials     1218     1217       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hlshen hlshen merged commit 4a17ca7 into master Mar 26, 2024
35 checks passed
@hlshen hlshen deleted the hlshen/api branch March 26, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants