Increase memory for server function on Next.js with image optimization #7940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoortizz
reviewed
Nov 13, 2024
src/frameworks/index.ts
Outdated
Comment on lines
542
to
546
| if (frameworksBackend && framework === "next") { | ||
| if (await isUsingImageOptimization(getProjectPath(), ".next")) { | ||
| frameworksBackend.memory = "512MiB"; | ||
| } | ||
| } |
There was a problem hiding this comment.
instead of doing it here, I’d move this to the Next.js files and return frameworksBackend overrides from ɵcodegenFunctionsDirectory, @jamesdaniels WDYT?
There was a problem hiding this comment.
I refactored this to do it in the Next.js file.
src/frameworks/index.ts
Outdated
| @@ -538,6 +539,12 @@ ${ | |||
|
|
|||
| // TODO move to templates | |||
|
|
|||
| if (frameworksBackend && framework === "next") { | |||
| if (await isUsingImageOptimization(getProjectPath(), ".next")) { | |||
There was a problem hiding this comment.
don't we need to do this only for Next 15?
There was a problem hiding this comment.
The memory issue is happening on Next 14 and 13 as well 🫠
leoortizz
reviewed
Nov 16, 2024
Comment on lines
+542
to
+543
| ...functionsDirectoryFrameworksBackend, | ||
| ...frameworksBackend, |
There was a problem hiding this comment.
I think functionsDirectoryFrameworksBackend should come after so it can override the default values?
There was a problem hiding this comment.
I'm thinking that the user could set the memory to a higher value, in that case we should not override it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scenarios Tested
Sample Commands