Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup initial App Check testapp #672

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Setup initial App Check testapp #672

merged 1 commit into from
Apr 13, 2023

Conversation

a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

This is copied from the Storage testapp. The changes are:

  • Renaming the folder Assets/Firebase/Sample/Storage -> AppCheck
  • Clearing out most of the contents of UIHandler.cs and UIHandlerAutomated.cs
  • Updating the Application identifier in ProjectSettings.asset
  • Updating the readme

Testing

Describe how you've tested these changes.

Building it locally


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice requested a review from AlmostMatt April 11, 2023 23:15
Copy link
Contributor

@AlmostMatt AlmostMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. I wonder if readme might need some additional instructions for setting up AppCheck in the Firebase console, but that can be added after the testapp has more logic.

@a-maurice a-maurice merged commit 8224b90 into main Apr 13, 2023
@a-maurice a-maurice deleted the am-app_check_testapp branch April 13, 2023 18:37
@firebase firebase locked and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants