Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Messaging calls #694

Merged
merged 1 commit into from
May 3, 2023
Merged

Remove deprecated Messaging calls #694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ Support

Release Notes
-------------
### 11.0.0
- Changes
- Messaging: Remove deprecated calls `Send`, `Subscribe`, and `Unsubscribe`.

### 10.7.0
- Changes
- General: Update to Firebase C++ SDK version 10.7.0.
Expand Down
36 changes: 0 additions & 36 deletions messaging/src/swig/messaging.i
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,39 +543,6 @@ void* NotificationCopyAndroidNotificationParams(void* notification) {
}
#endif // DOXYGEN

#if DOXYGEN
/// @brief Subscribe to receive all messages to the specified topic.
///
/// Subscribes an app instance to a topic, enabling it to receive messages sent to that topic.
///
/// Call this function from the main thread. FCM is not thread safe.
///
/// @param[in] topic The name of the topic to subscribe. Must match the following regular expression: `[a-zA-Z0-9-_.~%]{1,900}`.
[System.Obsolete("FirebaseMessaging.Subscribe is deprecated. Please use FirebaseMessaging.SubscribeAsync() instead")]
public static void Subscribe(string topic);
#else
[System.Obsolete("FirebaseMessaging.Subscribe is deprecated. Please use FirebaseMessaging.SubscribeAsync() instead")]
public static void Subscribe(string topic) {
SubscribeAsync(topic);
}
#endif

#if DOXYGEN
/// @brief Unsubscribe from a topic.
///
/// Unsubscribes an app instance from a topic, stopping it from receiving any further messages sent to that topic.
///
/// Call this function from the main thread. FCM is not thread safe.
///
/// @param[in] topic The name of the topic to unsubscribe from. Must match the following regular expression: `[a-zA-Z0-9-_.~%]{1,900}`.
[System.Obsolete("FirebaseMessaging.Unsubscribe is deprecated. Please use FirebaseMessaging.UnsubscribeAsync() instead")]
public static void Unsubscribe(string topic);
#else
[System.Obsolete("FirebaseMessaging.Unsubscribe is deprecated. Please use FirebaseMessaging.UnsubscribeAsync() instead")]
public static void Unsubscribe(string topic) {
UnsubscribeAsync(topic);
}
#endif
%}

%typemap(cscode) firebase::messaging::Message %{
Expand Down Expand Up @@ -695,9 +662,6 @@ void* NotificationCopyAndroidNotificationParams(void* notification) {
%csmethodmodifiers firebase::messaging::DeleteToken()
"internal"

%csmethodmodifiers firebase::messaging::Send(const Message&)
"[System.Obsolete(\"FirebaseMessaging.Send is deprecated and will be removed in a future version.\")]\n "

// Messaging has a lot of read-only properties, so make all immutable
// and call out the mutable ones.
%immutable;
Expand Down